From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 46A201FF0B7 for ; Fri, 13 Nov 2026 13:48:01 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 67481216EF; Fri, 13 Nov 2026 13:47:50 +0100 (CET) Content-Type: text/plain; charset=UTF-8 Date: Fri, 13 Nov 2026 13:47:43 +0100 Message-Id: Subject: Re: [PATCH qemu-server v7 05/32] helpers: move get_node_pvecfg_version() version helper to pve-cluster From: =?utf-8?q?Michael_K=C3=B6ppl?= To: "Fiona Ebner" , Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: aerc 0.22.0 References: <20261112115001.107306-1-f.ebner@proxmox.com> <20261112115001.107306-6-f.ebner@proxmox.com> In-Reply-To: <20261112115001.107306-6-f.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794574063460 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.195 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XQM3FPEVOW632QRMR2UW7IMT3ACNYD7P X-Message-ID-Hash: XQM3FPEVOW632QRMR2UW7IMT3ACNYD7P X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Reviewed-by: Michael K=C3=B6ppl On Thu Nov 12, 2026 at 12:48 PM CET, Fiona Ebner wrote: > To prepare for pve-container to check node versions too. While at it, > switch to node_pvecfg_version_at_least() to simplify the code. > > Drop the now unused JSON and PVE::Cluster imports. > > Mock the new node_pvecfg_version_at_least() function for the migration > tests, to make sure that a build host which is not part of a cluster [snip]