From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 90FBC1FF0B7 for ; Fri, 13 Nov 2026 13:47:11 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id CD1552164C; Fri, 13 Nov 2026 13:47:05 +0100 (CET) Content-Type: text/plain; charset=UTF-8 Date: Fri, 13 Nov 2026 13:46:58 +0100 Message-Id: Subject: Re: [PATCH guest-common v7 02/32] abstract migrate: declare fork_tunnel() as an abstract method From: =?utf-8?q?Michael_K=C3=B6ppl?= To: "Fiona Ebner" , Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 X-Mailer: aerc 0.22.0 References: <20261112115001.107306-1-f.ebner@proxmox.com> <20261112115001.107306-3-f.ebner@proxmox.com> In-Reply-To: <20261112115001.107306-3-f.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794574018427 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.197 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: NT2LPOMW35O7KES5D6QJ6GWF2LBTFO56 X-Message-ID-Hash: NT2LPOMW35O7KES5D6QJ6GWF2LBTFO56 X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Reviewed-by: Michael K=C3=B6ppl On Thu Nov 12, 2026 at 12:48 PM CET, Fiona Ebner wrote: > To be used in a common check_config_on_target() method. nit: this is `prepare_local_cluster_checks()`, no? > > Signed-off-by: Fiona Ebner > --- > > New in v7. > > src/PVE/AbstractMigrate.pm | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/src/PVE/AbstractMigrate.pm b/src/PVE/AbstractMigrate.pm > index 4be5261..ee64230 100644 > --- a/src/PVE/AbstractMigrate.pm > +++ b/src/PVE/AbstractMigrate.pm > @@ -256,6 +256,12 @@ sub migrate { > $self->log('info', "migration finished successfully (duration $durat= ion)"); > } > > +sub fork_tunnel { > + my ($self, $ssh_forward_info) =3D @_; > + > + die "abstract method - implement me"; > +} > + > sub lock_vm { > my ($self, $vmid, $code, @param) =3D @_; >