From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id E7C721FF0B3 for ; Wed, 11 Nov 2026 16:40:17 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 355A821684; Wed, 11 Nov 2026 16:40:15 +0100 (CET) Content-Type: text/plain; charset=UTF-8 Date: Wed, 11 Nov 2026 16:40:11 +0100 Message-Id: From: =?utf-8?q?Michael_K=C3=B6ppl?= To: "Fiona Ebner" , Subject: Re: [PATCH qemu-server v6 17/26] api: migrate: allow forwarding certain migration properties to HA Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 X-Mailer: aerc 0.22.0 References: <20261103124831.139399-1-f.ebner@proxmox.com> <20261103124831.139399-18-f.ebner@proxmox.com> In-Reply-To: <20261103124831.139399-18-f.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794411611327 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.203 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: G46PV5ZMPWFOUCPKFQSXW4S57T4L33KE X-Message-ID-Hash: G46PV5ZMPWFOUCPKFQSXW4S57T4L33KE X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue Nov 3, 2026 at 1:48 PM CET, Fiona Ebner wrote: [snip] > - }, > + properties =3D> $migrate_json_properties, > }, > returns =3D> { > type =3D> 'string', > @@ -5702,9 +5713,20 @@ __PACKAGE__->register_method({ > my $hacmd =3D sub { > my $upid =3D shift; > > - print "Requesting HA migration for VM $vmid to node $tar= get\n"; > - > + my $extra_opts =3D ''; > my $cmd =3D ['ha-manager', 'migrate', "vm:$vmid", $targe= t]; > + for my $prop (sort keys $ha_migrate_props->%*) { > + if (defined(my $value =3D $param->{$prop})) { > + push($cmd->@*, "--$prop", $value); > + $extra_opts .=3D ', ' if $extra_opts; > + $extra_opts .=3D "$prop=3D$value"; > + } > + } Only tangentially related, but because I noticed that this came up previously [0]: when migrating a *stopped* VM through the GUI, the checkbox for 'with-conntrack-state' is hidden, but the dialog still sends 'with-conntrack-state: 1', which migrate_vm then overrides with 0 again. The task log then shows "(with-conntrack-state=3D0)" and the CRM receives command `migrate vm:100 pve2-ceph {"with-conntrack-state":"0"}`. To me, this looks like a purely cosmetic issue, though, and I'm not sure it's worth changing how params are forwarded here. [0] https://lore.proxmox.com/pve-devel/8c0157e4-e8a9-4ed8-8d08-98ed82f18a0e= @proxmox.com/ > + > + my $msg =3D "Requesting HA migration for VM $vmid to nod= e $target"; > + $msg .=3D " (${extra_opts})" if $extra_opts; > + print "$msg\n"; > + > run_command($cmd); > return; > };