all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Max R. Carrara" <m.carrara@proxmox.com>
To: "Wolfgang Bumiller" <w.bumiller@proxmox.com>
Cc: pve-devel@lists.proxmox.com,
	Alfonso Kuen <gerencia@idkmanager.com>,
	Thomas Ellmenreich <t.ellmenreich@proxmox.com>,
	Jakob Klocker <j.klocker@proxmox.com>
Subject: Re: [PATCH pve-storage v4 02/17] api: plugins/storage: add initial routes and endpoints
Date: Wed, 11 Nov 2026 11:58:20 +0100	[thread overview]
Message-ID: <DMSBU19F96HP.DQSZO1TRU44J@proxmox.com> (raw)
In-Reply-To: <y3qwkv3vew5dr253eqzmgf6el2iwlq36nlz6vmprxjgjono62g@petflded7fud>

On Tue Nov 10, 2026 at 3:35 PM CET, Wolfgang Bumiller wrote:
> On Fri, Nov 06, 2026 at 04:45:38PM +0100, Max R. Carrara wrote:
> > Add the following routes / endpoints:
> >
> > * `GET plugins/storage`
> >   Directory index, listing the direct child path components (so,
> >   just 'plugin' currently).
> >
> > * `GET plugins/storage/plugin`
> >   Lists all installed storage plugins and their metadata.
> >   Currently, this is just an array of objects, with each object
> >   containing the plugin's `type()` and Perl module path.
>
> Exposing perl module paths over the API is not a great idea. Consider
> what this would look like when we add/move over to rust or other plugin
> types.
> API-wise we should only care about the type I think. UI/UX wise, plugins
> could get a "display name", version (plugin side, not checked by us at
> all), author, license fields plugins could fill if they want to,
> alongside a non-overideable "built-in" flag sent by the API?

Yeah that makes sense and sounds good to me; I'll see if I can add those
fields in v5 then, probably as part of `plugindata()`.

Thanks!

>
> >
> > * `GET plugins/storage/plugin/{type}`
> >   Returns the metadata for a single plugin given by `{type}`.
> >
> > Signed-off-by: Max R. Carrara <m.carrara@proxmox.com>
> > ---
> >  src/PVE/API2/Makefile                  |   1 +
> >  src/PVE/API2/Plugins/Makefile          |  18 +++++
> >  src/PVE/API2/Plugins/Storage.pm        |  52 ++++++++++++
> >  src/PVE/API2/Plugins/Storage/Makefile  |  17 ++++
> >  src/PVE/API2/Plugins/Storage/Plugin.pm | 106 +++++++++++++++++++++++++
> >  5 files changed, 194 insertions(+)
> >  create mode 100644 src/PVE/API2/Plugins/Makefile
> >  create mode 100644 src/PVE/API2/Plugins/Storage.pm
> >  create mode 100644 src/PVE/API2/Plugins/Storage/Makefile
> >  create mode 100644 src/PVE/API2/Plugins/Storage/Plugin.pm
> >
>
> 8< snip >8





  reply	other threads:[~2026-11-11 10:58 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 15:45 [PATCH common/manager/proxmox-widget-toolkit/storage/storage-plugin-examples v4 00/17] GUI Support for Custom Storage Plugins Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-common v4 01/17] json schema: add multiline string format Max R. Carrara
2026-11-10 13:39   ` Wolfgang Bumiller
2026-11-11 10:56     ` Max R. Carrara
2026-11-11 11:38       ` Thomas Lamprecht
2026-11-11 13:50         ` Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-storage v4 02/17] api: plugins/storage: add initial routes and endpoints Max R. Carrara
2026-11-10 14:35   ` Wolfgang Bumiller
2026-11-11 10:58     ` Max R. Carrara [this message]
2026-11-06 15:45 ` [PATCH pve-storage v4 03/17] api: plugins/storage/plugin: include schema in plugin metadata Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-storage v4 04/17] api: plugins/storage/plugin: mark sensitive properties in schema Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-storage v4 05/17] api: plugins/storage/plugin: factor plugin metadata code into helper Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-storage v4 06/17] api: plugins/storage/plugin: add plugins' 'content' to their metadata Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-storage v4 07/17] all plugins: add 'title' to properties, adapt 'description's Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-storage v4 08/17] all plugins, api: mark certain properties as advanced in plugindata() Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-storage v4 09/17] all plugins, api: mark certain properties as hidden " Max R. Carrara
2026-11-06 15:45 ` [PATCH proxmox-widget-toolkit v4 10/17] form: introduce new 'proxmoxtextarea' field Max R. Carrara
2026-11-06 15:45 ` [PATCH proxmox-widget-toolkit v4 11/17] utils: introduce helper function getFieldDefFromPropertySchema Max R. Carrara
2026-11-06 15:45 ` [PATCH proxmox-widget-toolkit v4 12/17] acme: use helper to construct ExtJS fields from property schemas Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-manager v4 13/17] api: sort modules and API method registrations Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-manager v4 14/17] api: add API routes 'plugins' and 'plugins/storage' Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-manager v4 15/17] ui: storage view: display error when no editor for storage type exists Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-manager v4 16/17] ui: storage: add basic UI integration for custom storage plugins Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-storage-plugin-examples v4 17/17] sshfs: Update SSHFS plugin Max R. Carrara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMSBU19F96HP.DQSZO1TRU44J@proxmox.com \
    --to=m.carrara@proxmox.com \
    --cc=gerencia@idkmanager.com \
    --cc=j.klocker@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.ellmenreich@proxmox.com \
    --cc=w.bumiller@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal