From: "Thomas Ellmenreich" <t.ellmenreich@proxmox.com>
To: "Filip Schauer" <f.schauer@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH proxmox 0/3] oci: refactor code
Date: Mon, 09 Nov 2026 14:34:05 +0100 [thread overview]
Message-ID: <DMQPW74MDI5M.3NAREZM2A1Y7V@proxmox.com> (raw)
In-Reply-To: <20261103151153.290754-1-f.schauer@proxmox.com>
Thanks for the patch and a good refactor in my opinion.
I was just thinking that it might make sense to have a few more specific
unit tests. As I see it, currently the tests cover most of the code, but
only indirectly. That said, this is not super necessary, just wanted to
mention it.
Reviewed-by: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
prev parent reply other threads:[~2026-11-09 13:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 15:11 [PATCH proxmox 0/3] oci: refactor code Filip Schauer
2026-11-03 15:11 ` [PATCH proxmox 1/3] oci: add a digest helper module Filip Schauer
2026-11-03 15:11 ` [PATCH proxmox 2/3] oci: reduce redundant layer decompression during extraction Filip Schauer
2026-11-03 15:11 ` [PATCH proxmox 3/3] oci: factor out parsing and extraction into modules Filip Schauer
2026-11-09 13:34 ` Thomas Ellmenreich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMQPW74MDI5M.3NAREZM2A1Y7V@proxmox.com \
--to=t.ellmenreich@proxmox.com \
--cc=f.schauer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.