From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 4478F1FF09C for ; Mon, 02 Nov 2026 15:55:19 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id A5491216EF; Mon, 02 Nov 2026 15:55:16 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 02 Nov 2026 15:55:10 +0100 Message-Id: Subject: Re: [PATCH installer v4 25/30] tui: network: add bond setup options to advanced network dialog From: "Lukas Sichert" To: "Christoph Heiss" , References: <20261102124539.1008075-1-c.heiss@proxmox.com> <20261102124539.1008075-26-c.heiss@proxmox.com> In-Reply-To: <20261102124539.1008075-26-c.heiss@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793631310971 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.549 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: TF7GBF3UJHEU5EQMNXKMYWALP2LGZUPD X-Message-ID-Hash: TF7GBF3UJHEU5EQMNXKMYWALP2LGZUPD X-MailFrom: l.sichert@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2026-11-02 13:45, Christoph Heiss wrote: > Partially fixes #2164 [0]. > > Adds a second panel to the advanced network options dialog, allowing to > enable bonding and setting all the required options for it; such as > members, mode, hash policy and primary bond member, as required. > > [0] https://bugzilla.proxmox.com/show_bug.cgi?id=3D2164 > > Signed-off-by: Christoph Heiss Thanks for sending the patch, I like the new section based Interface, just one Nit: When setting a primary-interface in the active-backup mode and then later switching to a different Bond-mode, the bond primary field is not cleared, but deactived. Applying is therefore not possible because of 'primary bond interface can only be set in active-backup mode', but also the primary bond interface cannot be unset as it is deactivated.