From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Mark Atwood" <mark@wolfssl.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH access-control] csrf: drop leftover SHA-1 token fallback
Date: Mon, 02 Nov 2026 15:06:50 +0100 [thread overview]
Message-ID: <DMKS7GRUSIMA.18Q3LD0FQX88G@proxmox.com> (raw)
In-Reply-To: <20261023185755.541328-1-mark@wolfssl.com>
On Fri Oct 23, 2026 at 8:57 PM CEST, Mark Atwood wrote:
> verify_csrf_prevention_token still derives a SHA-1 based secret from the
> www key and switches to it for tokens with a 27 character signature, as
> issued by PVE 5 and older.
>
> This fallback stopped working when pve-common commit ff39327 ("ticket:
> remove fallback for SHA1-base64 CSRF prevention tokens") made
> PVE::Ticket::verify_csrf_prevention_token always compute an
> HMAC-SHA-256, whose 43 character signature can never match a 27
> character one. Such tokens are therefore rejected either way, and the
> build dependency on libpve-common-perl (>= 9.1.11) already pulls in that
> change.
>
> Remove the dead code, including the FIXME that asked for its removal
> with PVE 7. This also drops the last SHA-1 use from CSRF handling.
-->8 snip 8<--
Hey Mark,
thanks for this patch, looks good from my perspective. Did a quick test
and everything still seems to work as expected. Consider this:
Reviewed-by: Shannon Sterz <s.sterz@proxmox.com>
Tested-by: Shannon Sterz <s.sterz@proxmox.com>
prev parent reply other threads:[~2026-11-02 14:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 18:57 [PATCH access-control] csrf: drop leftover SHA-1 token fallback Mark Atwood
2026-11-02 14:06 ` Shannon Sterz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMKS7GRUSIMA.18Q3LD0FQX88G@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=mark@wolfssl.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.