all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Elias Huhsovitz" <e.huhsovitz@proxmox.com>
To: "Hannes Laimer" <h.laimer@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH pve-container] lxc: pass hostname correctly when giving up an ip address
Date: Fri, 23 Oct 2026 13:29:52 +0200	[thread overview]
Message-ID: <DMC6LTW2ZVG8.C3TOUX5K1WK@proxmox.com> (raw)
In-Reply-To: <20260819133459.915481-1-h.laimer@proxmox.com>

Needs rebase onto master.

I was unable to find any mention of a container 'name' in the guest config.

I checked the config for all of my containers, and the $conf in 
always contains a 'hostname' key, never a 'name'.

So consider this

Reviewed-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>
Tested-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>

On Wed Aug 19, 2026 at 3:34 PM CEST, Hannes Laimer wrote:
> A container has no `name`, only a `hostname`. This led to left behind
> DNS records.
>
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
>  src/PVE/LXC/Config.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
> index 7c81834..41dd22f 100644
> --- a/src/PVE/LXC/Config.pm
> +++ b/src/PVE/LXC/Config.pm
> @@ -1850,7 +1850,7 @@ sub vmconfig_apply_pending {
>                              PVE::Network::SDN::Vnets::del_ips_from_mac(
>                                  $old_net->{bridge},
>                                  $old_net->{hwaddr},
> -                                $conf->{name},
> +                                $conf->{hostname},
>                              );
>                              PVE::Network::SDN::Vnets::add_next_free_cidr(
>                                  $net->{bridge},





      reply	other threads:[~2026-10-23 11:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-19 13:34 [PATCH pve-container] lxc: pass hostname correctly when giving up an ip address Hannes Laimer
2026-10-23 11:29 ` Elias Huhsovitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMC6LTW2ZVG8.C3TOUX5K1WK@proxmox.com \
    --to=e.huhsovitz@proxmox.com \
    --cc=h.laimer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal