From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40])
	by lore.proxmox.com (Postfix) with ESMTPS id 110CC1FF0C0
	for <inbox@lore.proxmox.com>; Wed, 21 Oct 2026 16:12:54 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 16A5121605;
	Wed, 21 Oct 2026 16:12:51 +0200 (CEST)
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Wed, 21 Oct 2026 16:12:47 +0200
Message-Id: <DMAKTH38235H.3EIHNTIBX7ZZ1@proxmox.com>
From: "Lukas Sichert" <l.sichert@proxmox.com>
To: "Christoph Heiss" <c.heiss@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH installer 09/15] gui: network: factor out name pinning
 into advanced options dialog
References: <20261020112327.641633-1-c.heiss@proxmox.com>
 <20261020112327.641633-10-c.heiss@proxmox.com>
In-Reply-To: <20261020112327.641633-10-c.heiss@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1792591967274
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.618 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: 2V64SZYGR4CCCXEZB5LWIQUQEUC6YQ4D
X-Message-ID-Hash: 2V64SZYGR4CCCXEZB5LWIQUQEUC6YQ4D
X-MailFrom: l.sichert@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On 2026-10-20 13:23, Christoph Heiss <c.heiss@proxmox.com> wrote:

> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>

> diff --git a/proxinstall b/proxinstall
> index 51efe79..e3a4b20 100755


> +# takes an array ref of rows with [$label_text, $widget, $suffix_label] =
array refs as columns
> +# $suffix_label is optional
> +my $create_label_widget_grid =3D sub {
> +    my ($labeled_widgets) =3D @_;



> -# takes an array ref of rows with [$label_text, $widget, $suffix_label] =
array refs as columns
> -# $suffix_label is optional
> -my $create_label_widget_grid =3D sub {
> -    my ($labeled_widgets) =3D @_;

Nit: I think moving this function should be done in the next or a
seperate commit as the required call only gets added in the 'gui:
network: add bond setup options to advanced options dialog' commit.