From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 618E41FF0AB for ; Wed, 21 Oct 2026 10:06:10 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id E5EC32145A; Wed, 21 Oct 2026 10:06:07 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 21 Oct 2026 10:06:03 +0200 Message-Id: Subject: Re: [PATCH storage v2 0/7] add native ZFS over NVMe/TCP backend To: "Joaquin Varela" From: "Max R. Carrara" X-Mailer: aerc 0.18.2-0-ge037c095a049 References: <20261005002719.1600-1-joaquinvarela@neatech.ar> In-Reply-To: <20261005002719.1600-1-joaquinvarela@neatech.ar> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792569963703 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.345 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XGOAN5FTSIUJMHONA7CQMS3Z5WRWWU7T X-Message-ID-Hash: XGOAN5FTSIUJMHONA7CQMS3Z5WRWWU7T X-MailFrom: m.carrara@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon Oct 5, 2026 at 2:27 AM CEST, Joaquin Varela wrote: > Hi Max, > > thank you very much for the detailed review, and sorry that it took a > few days. I have just sent v3 ("[PATCH storage v3 0/4] add ZFS over > NVMe/TCP storage plugin"), together with the docs and manager patches. > It addresses all three points and the helper suggestions: the plugin > inherits from PVE::Storage::Plugin, LunCmd::NVMET is gone, ZFS/configfs > parsing and operation planning are local. In patch 1/4 the target runs > quoted simple commands, > sometimes joined with '&&', plus one pipe that writes the key, and the > PVE helpers replace the builtins. > Instead of dir_glob_regex, which returns only the first match, the > sysfs walks nest dir_glob_foreach. > > Two parts are questions for you, explained in the cover letter: an > optional patch that guards transaction commands on the target against a > delayed command of an abandoned operation, which adds target-side > validation and a small sh guard with the only shell control flow on the > target, and a longer default > wait for the shared storage lock. Both are separate patches, so either > can be dropped without touching the other storage patches (dropping > the guard also drops one sentence and one paragraph of the docs > patch). If the size of the series gets in the way, I can split the > backend patch and split or trim the tests. > > The contribution is limited to the storage backend and its integration > with PVE. It does not implement target high availability, pool takeover > or target fencing. The optional guard protects control-plane operations > on a single target too; it is not host or guest-I/O fencing. Multi-head > target compatibility remains conditional and has not been qualified. > > The v3 cover Message-ID is: > <20261005002609.571-1-joaquinvarela@neatech.ar> > > v3 also refuses storages that share an NVMe/TCP listener on the > target, because after a target restart they could lose their > controllers. The cover letter has the details. > > Kind regards, > Joaquin Varela Hi Joaquin! Thank you very much for refreshing the series! I will do a re-review at my earliest convenience. =F0=9F=AB=A1 - Max