Re: [PATCH qemu-server v3 13/21] api: migrate: allow forwarding certain migration properties to HA

["Daniel Kral" <d.kral@proxmox.com>]

On Fri Sep 18, 2026 at 6:08 PM CEST, Fiona Ebner wrote:
> diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm
> index 71247eec..b5a850a3 100644
> --- a/src/PVE/API2/Qemu.pm
> +++ b/src/PVE/API2/Qemu.pm
> @@ -5641,9 +5652,18 @@ __PACKAGE__->register_method({
>              my $hacmd = sub {
>                  my $upid = shift;
>  
> -                print "Requesting HA migration for VM $vmid to node $target\n";
> -
> +                my $extra_opts = '';
>                  my $cmd = ['ha-manager', 'migrate', "vm:$vmid", $target];
> +                for my $prop (sort keys $ha_migrate_props->%*) {
> +                    if (defined(my $value = $param->{$prop})) {
> +                        push($cmd->@*, "--$prop", $value);
> +                        $extra_opts .= ',';
> +                        $extra_opts .= " $prop=$value";
> +                    }
> +                }
> +
> +                print "Requesting HA migration for VM $vmid to node ${target}${extra_opts}\n";

--with-conntrack-state is always set to either 0 or 1, so essentially
any output will always contain at least

Requesting HA migration for VM 100 to node node1, with-conntrack-state=0

or

Requesting HA migration for VM 100 to node node1, with-conntrack-state=1


Unrelated to the patch series, but in this specific case it would
probably suffice to not explicitly set $param->{'with-conntrack-state'}
to 0 if not requested by the user directly.


Might be nice to use parenthesis here and for pve-container as well, so
that the less important information (the migration options) are more
separated from the main message (the requested migration):

Requesting HA migration for VM 100 to node node1 (with-conntrack-state=1)

> +
>                  run_command($cmd);
>                  return;
>              };