From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 46BD01FF09B for ; Mon, 12 Oct 2026 14:16:40 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 17AF2213A3; Mon, 12 Oct 2026 14:16:40 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 12 Oct 2026 14:16:36 +0200 Message-Id: Subject: Re: [PATCH proxmox 3/6] log: cleanup of logger components From: "Lukas Wagner" To: "Thomas Ellmenreich" , X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20261007074527.102419-1-t.ellmenreich@proxmox.com> <20261007074527.102419-4-t.ellmenreich@proxmox.com> In-Reply-To: <20261007074527.102419-4-t.ellmenreich@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1791807396762 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.311 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 7RAEW5LGBWW7SM5NMAOALSZT2NA3QUGN X-Message-ID-Hash: 7RAEW5LGBWW7SM5NMAOALSZT2NA3QUGN X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed Oct 7, 2026 at 9:45 AM CEST, Thomas Ellmenreich wrote: > Simplify the logger code. The cleanups performed were: > - Removed some explicit module paths in favour of imports > - Simplified an empty struct by converting it to a unit struct. > - Instead of creating a unit struct as an empty struct, decided > to instantiate it as a unit struct. > > Signed-off-by: Thomas Ellmenreich Reviewed-by: Lukas Wagner