From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 205881FF09B for ; Mon, 12 Oct 2026 14:16:07 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id E213E2133C; Mon, 12 Oct 2026 14:16:06 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 12 Oct 2026 14:15:59 +0200 Message-Id: Subject: Re: [PATCH datacenter-manager 6/6] api: update logging variable From: "Lukas Wagner" To: "Thomas Ellmenreich" , X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20261007074527.102419-1-t.ellmenreich@proxmox.com> <20261007074527.102419-7-t.ellmenreich@proxmox.com> In-Reply-To: <20261007074527.102419-7-t.ellmenreich@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1791807359635 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.313 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: EFBI245PZM57ZSWQ37D4ZV7X6SIVWLTN X-Message-ID-Hash: EFBI245PZM57ZSWQ37D4ZV7X6SIVWLTN X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed Oct 7, 2026 at 9:45 AM CEST, Thomas Ellmenreich wrote: > Update the variable used to set the log level for the datacenter-api. The > old 'PROXMOX_DEBUG' variable is replaced by 'PDM_LOG' to match the > pattern used by all other products. > > If 'PROXMOX_DEBUG' is set in the environment, a warning is emitted so > that administrators may switch to the new variable. > > Suggested-by: Lukas Wagner > Signed-off-by: Thomas Ellmenreich Btw, there is also another daemon where this should be fixed in server/src/bin/proxmox-datacenter-privileged-api.rs (the privileged API daemon running as root) All other binaries in the project already seem to be using "PDM_LOG". As mentioned earlier, this might be something that could/should wait until the next major release. Might be also fine to just change it right away, the environment variable is not documented anywhere. @Gabriel, do you have any opinions on the proxmox.git patches? > --- > server/src/bin/proxmox-datacenter-api/main.rs | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/server/src/bin/proxmox-datacenter-api/main.rs b/server/src/b= in/proxmox-datacenter-api/main.rs > index 2fc84c1d..fa8c2eb1 100644 > --- a/server/src/bin/proxmox-datacenter-api/main.rs > +++ b/server/src/bin/proxmox-datacenter-api/main.rs > @@ -47,11 +47,18 @@ fn main() -> Result<(), Error> { > =20 > server::env::sanitize_environment_vars(); > =20 > - proxmox_log::Logger::from_env("PROXMOX_DEBUG", LevelFilter::INFO) > + proxmox_log::Logger::from_env("PDM_LOG", LevelFilter::INFO) > .journald_on_no_workertask() > .tasklog_pbs() > .init()?; > =20 > + // TODO: remove after a few versions > + if std::env::var("PROXMOX_DEBUG").is_ok() { > + proxmox_log::warn!( > + "to set the log level, please use the PDM_LOG variable, as i= t has replaced PROXMOX_DEBUG" > + ); > + } > + > let debug =3D proxmox_log::enabled!(Level::DEBUG); > =20 > if std::env::args().nth(1).is_some() {