Re: [PATCH manager v3 38/39] api: notification: reject matchers with expression if not supported by all nodes

["Lukas Wagner" <l.wagner@proxmox.com>]

On Fri Oct 9, 2026 at 2:56 PM CEST, Lukas Wagner wrote:
> The new matcher UI will automatically migrate any existing matcher to
> one with an 'expression', and new matchers will also only use this new
> parameter. If any of the cluster nodes uses a version of pve-manager
> that does not yet support the new parameter, any matcher written by an
> updated node will break notifications on the older nodes.
>
> To avoid this, on create/update, we now reject matchers with an
> 'expression' parameter if any of the online cluster nodes is still
> running on a too old version of pve-manager. While this still leaves the
> possibility of an outdated, offline node coming back online and then
> failing to parse the migrated notification config, it would be
> unreasonable to disallow editing the notification configuration if any
> node is offline.

[snip]

> +my $matcher_expressions_version = "9.2.21";
> +my $matcher_expressions_version_array = [9, 2, 21];
> +
> +my sub matcher_expressions_supported {
> +    my $version_info = PVE::Cluster::get_node_kv('version-info');
> +    for my $node (sort keys $version_info->%*) {
> +        my $node_info = eval { JSON::decode_json($version_info->{$node}); };
> +        if (my $err = $@) { # warn, but continue
> +            syslog('warn', "cannot parse version info for $node as JSON - $err");
> +        } elsif (!PVE::Cluster::pvecfg_min_version($node_info->{version}, @$matcher_expressions_version_array)) {
> +            return 0;
> +        }

Forgot to run `make tidy` here -- will include it in v4 if there will be
one, but otherwise this can just be fixed up when applying this.