From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 82FCD1FF0B7 for ; Fri, 02 Oct 2026 11:24:39 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id A03172165A; Fri, 02 Oct 2026 11:24:38 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 02 Oct 2026 11:24:34 +0200 Message-Id: Subject: Re: [PATCH datacenter-manager v4 00/10] refactor and partially fix #7371 From: "Lukas Wagner" To: "Dominik Csapak" , X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260923131857.2953139-1-d.csapak@proxmox.com> In-Reply-To: <20260923131857.2953139-1-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1790933074708 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.393 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XNNIPENJCTQQDGIJ2S5KXGNHDGJYFDZ7 X-Message-ID-Hash: XNNIPENJCTQQDGIJ2S5KXGNHDGJYFDZ7 X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed Sep 23, 2026 at 3:17 PM CEST, Dominik Csapak wrote: > the first 6 patches are pure refactors and should not change anything > user visible, could be applied independently. > > patch 7,8,10 partially fix #7371 by showing the HA maintenance status > of PVE nodes in various places. > > patch 9 is just a fix that came up (thanks @lukas) > > chagnes from v3: > * rebase on master > * add serde skip_serialize_if for option none on the ha maintenance field > * added new patch for sorting by memory usage correctly > > changes from v2: > * add missing doc comments > * refine wording a bit and make it more consistent (HA -> ha for example) > * change from string 'hastate' to proper rust enum 'ha-state' in > PveNodeResource struct > > changes from v1: > * fixed some display problems: NaN% when maxmem was set to 0.0, > 0.0% cpu when the node was offline, fixed by not showing values for > offline nodes > * add a new patch for showing tha badge too in the node card's title > * various typo fixes > * added #[serde(default)] to the new hastate field to allow > deserialization from older versions > * some smaller fixes (left over comments, naming, etc.) > > Thanks for these patches! One minor thing that I discovered while testing this series again: The node name is now cut-off by the HA badge if the viewport is on the smaller side (tested it with 1600px width, which is not *that* narrow). Off-list, we already discussed this issue, we agreed that one solution would be to move the guest tags to the same column as the name (same as in PVE) and to remove the formerly dedicated tag column completely, giving the name + tag + badge column a lot more space in total. We agreed that removing the tag column would be a separate patch that can be independently applied, and then this series can be rebased on top of that.