Re: [PATCH proxmox v2 3/4] log: add tests to the logger

["Lukas Wagner" <l.wagner@proxmox.com>]

On Wed Sep 23, 2026 at 1:58 PM CEST, Thomas Ellmenreich wrote:
> Add tests to ensure consistent functionality when setting the logging
> environment variable, as well as global filtering of logs.
>
> Although the EnvFilter itself is not something we should be testing, we are
> adding some additional machinery, on top of the extensive functionality
> provided by tracing/tracing_subscriber, which does need testing.
>

[...]


>      /// If present, tries to parse the `env_filter_str` as a [`EnvFilter`],
>      /// otherwiese falls back to the provided default log level.
>      ///
> @@ -170,3 +178,281 @@ impl Logger {
>      }
>  }

Thanks a lot for writing tests for this!

For completeness, you might also change some of the tests (or add 1-2
new ones) to emit native tracing events (e.g. tracing::info!), right now
you only emit log events (either directly through the `log` crate or
through `tracing_log::log`). The risk that one works and the other does
not is minimal, but while at it it certainly does not hurt.

Also please check `cargo clippy --tests`, there are some minor warnings
here (also about overindented documentation).

>  
> +#[cfg(test)]
> +mod tests {
> +    use std::sync::{Arc, Mutex};
> +
> +    use tracing::level_filters::LevelFilter;
> +    use tracing_log::log;
> +    use tracing_subscriber::{Layer, util::SubscriberInitExt};