Re: [PATCH manager] fix #6475: ui: upload: only show the file name of the selected file

["Max R. Carrara" <m.carrara@proxmox.com>]

On Mon Sep 28, 2026 at 4:02 PM CEST, Max R. Carrara wrote:
> On Sat Sep 26, 2026 at 10:49 AM CEST, Michal Fox wrote:
> > For privacy reasons, browsers do not expose the real path of a selected
> > file and prefix its name with 'C:\fakepath\' instead, on every
> > platform. The file field of the upload window shows this value as is,
> > which confuses users on Linux or macOS clients.
> >
> > Show the name of the selected file object instead. Only the displayed
> > value changes, the upload itself uses the file object and is not
> > affected.
> >
> > Signed-off-by: Michal Fox <me@dualfroz.com>
> > ---
>
> Gave this a spin on my workstation and can confirm that only the file's
> name is displayed. Code also looks fine to me.

Forgot to mention that I checked this on both Firefox and Chromium.
Works in both cases.

>
> LGTM! Thanks a lot for your contribution!
>
> Consider:
>
> Reviewed-by: Max R. Carrara <m.carrara@proxmox.com>
> Tested-by: Max R. Carrara <m.carrara@proxmox.com>
>
> >  www/manager6/window/UploadToStorage.js | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js
> > index cc53596d..8010e127 100644
> > --- a/www/manager6/window/UploadToStorage.js
> > +++ b/www/manager6/window/UploadToStorage.js
> > @@ -167,6 +167,8 @@ Ext.define('PVE.window.UploadToStorage', {
> >                  (fileInput.files[0] && Proxmox.Utils.format_size(fileInput.files[0].size)) || '-',
> >              );
> >              vm.set('mimetype', (fileInput.files[0] && fileInput.files[0].type) || '-');
> > +            // browsers hide the real path behind 'C:\fakepath\', so only show the file name
> > +            input.setRawValue(fileInput.files[0]?.name ?? '');
> >          },
> >
> >          hashChange: function (field, value) {