From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id D3B531FF0AB for ; Wed, 23 Sep 2026 09:48:06 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 6CB532146F; Wed, 23 Sep 2026 09:48:06 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 23 Sep 2026 09:48:01 +0200 Message-Id: Subject: Re: [PATCH datacenter-manager 5/5] api: set REST server debug level based on actual log level From: "Thomas Ellmenreich" To: "Thomas Ellmenreich" , X-Mailer: aerc 0.20.0 References: <20260921095210.229315-2-t.ellmenreich@proxmox.com> <20260921095210.229315-7-t.ellmenreich@proxmox.com> In-Reply-To: <20260921095210.229315-7-t.ellmenreich@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1790149681928 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.567 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: W3G6Q2NZL64V55KXSLFDABW5J4KT6V7S X-Message-ID-Hash: W3G6Q2NZL64V55KXSLFDABW5J4KT6V7S X-MailFrom: t.ellmenreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon Sep 21, 2026 at 11:51 AM CEST, Thomas Ellmenreich wrote: > Use the configuration returned by the initialised logger to decide whethe= r to > activate debugging for the REST server. > > Previously, whether the REST server was in debug mode would only be deter= mined > by the existence of the PROXMOX_DEBUG variable, regardless of its value. = Now, > if the environment variable is set to a less verbose level than 'debug', = the > REST server will not activate its debug level. > > Signed-off-by: Thomas Ellmenreich > --- > server/src/bin/proxmox-datacenter-api/main.rs | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/server/src/bin/proxmox-datacenter-api/main.rs b/server/src/b= in/proxmox-datacenter-api/main.rs > index 57aa6e22..7b2d85cb 100644 > --- a/server/src/bin/proxmox-datacenter-api/main.rs > +++ b/server/src/bin/proxmox-datacenter-api/main.rs > @@ -46,13 +46,15 @@ fn main() -> Result<(), Error> { > =20 > server::env::sanitize_environment_vars(); > =20 > - let debug =3D std::env::var("PROXMOX_DEBUG").is_ok(); > - > - proxmox_log::Logger::from_env("PROXMOX_DEBUG", LevelFilter::INFO) > + let log_config =3D proxmox_log::Logger::from_env("PROXMOX_DEBUG", Le= velFilter::INFO) > .journald_on_no_workertask() > .tasklog_pbs() > .init()?; > =20 > + // NOTE: this will now also activate if a very specific module is se= t > + // to debug but the default level is still on info > + let debug =3D log_config.global_filter_max_level_hint() >=3D LevelFi= lter::DEBUG; After working on another issue, I realised that the entire LoggerConfig par= t could be removed and replaced with a simple 'proxmox_log::enabled!', which would look like this: ``` let debug =3D proxmox_log::enabled!(LevelFilter::DEBUG); ``` This is cleaner and also removes the LoggerConfig, that is not really needed outside of this single instance. > + > if std::env::args().nth(1).is_some() { > bail!("unexpected command line parameters"); > }