From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 04DA61FF0B3 for ; Wed, 09 Sep 2026 11:47:25 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id F156F215D3; Wed, 09 Sep 2026 11:47:22 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 09 Sep 2026 11:47:18 +0200 Message-Id: To: "Hannes Laimer" Subject: Re: [PATCH pve-network] sdn: vxlan: fix max value for vxlan-port From: "Christoph Heiss" X-Mailer: aerc 0.22.0 References: <20260710060648.50963-1-h.laimer@proxmox.com> In-Reply-To: <20260710060648.50963-1-h.laimer@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1788947229997 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.328 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: UZKHLNUCMB5EMLYZ2J2ASSSTOJUOEPAW X-Message-ID-Hash: UZKHLNUCMB5EMLYZ2J2ASSSTOJUOEPAW X-MailFrom: c.heiss@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri Jul 10, 2026 at 8:06 AM CEST, Hannes Laimer wrote: > As per RFC 768[1] the port is only 16 bits, so the maximum value is > 65535. `ifupdown2` failed if 65536 was configured: Reviewed-by: Christoph Heiss Tested-by: Christoph Heiss FWIW, interestingly, ifupdown2 also specifies 0-65536 as range and thus accepts it. I'll send a patch fixing it there too. > > ``` > vxlan_yuuur : error: vxlan_yuuur: vxlan creation failed: 'H' format requi= res 0 <=3D number <=3D 65535 > yuuur : error: yuuur: bridge port vxlan_yuuur does not exist > ``` > > [1] https://datatracker.ietf.org/doc/html/rfc768 > > Signed-off-by: Hannes Laimer > --- > src/PVE/API2/Network/SDN/Zones.pm | 2 +- > src/PVE/Network/SDN/Zones/VxlanPlugin.pm | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/PVE/API2/Network/SDN/Zones.pm b/src/PVE/API2/Network/SDN= /Zones.pm > index b897cbd..e0b417b 100644 > --- a/src/PVE/API2/Network/SDN/Zones.pm > +++ b/src/PVE/API2/Network/SDN/Zones.pm > @@ -187,7 +187,7 @@ my $ZONE_PROPERTIES =3D { > description =3D> > "UDP port that should be used for the VXLAN tunnel (default = 4789). VXLAN zone only.", > minimum =3D> 1, > - maximum =3D> 65536, > + maximum =3D> 65535, > type =3D> 'integer', > optional =3D> 1, > default =3D> 4789, > diff --git a/src/PVE/Network/SDN/Zones/VxlanPlugin.pm b/src/PVE/Network/S= DN/Zones/VxlanPlugin.pm > index a408261..1d6d588 100644 > --- a/src/PVE/Network/SDN/Zones/VxlanPlugin.pm > +++ b/src/PVE/Network/SDN/Zones/VxlanPlugin.pm > @@ -35,7 +35,7 @@ sub properties { > 'vxlan-port' =3D> { > description =3D> "UDP port that should be used for the VXLAN= tunnel (default 4789).", > minimum =3D> 1, > - maximum =3D> 65536, > + maximum =3D> 65535, > type =3D> 'integer', > default =3D> 4789, > },