From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 6E0511FF09F for ; Thu, 03 Sep 2026 20:19:35 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 1AAEC214D6; Thu, 03 Sep 2026 20:19:34 +0200 (CEST) Content-Type: text/plain; charset=UTF-8 Date: Thu, 03 Sep 2026 20:19:28 +0200 Message-Id: From: =?utf-8?q?Michael_K=C3=B6ppl?= To: "Lukas Wagner" , Subject: Re: [PATCH datacenter-manager v5 11/21] context: register PdmApplication in router Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 X-Mailer: aerc 0.22.0 References: <20260903111609.267762-1-l.wagner@proxmox.com> <20260903111609.267762-12-l.wagner@proxmox.com> In-Reply-To: <20260903111609.267762-12-l.wagner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1788459565796 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.883 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: KLFSZMUKW43KTCK3WREXG7LSZ7K3EUKF X-Message-ID-Hash: KLFSZMUKW43KTCK3WREXG7LSZ7K3EUKF X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu Sep 3, 2026 at 1:15 PM CEST, Lukas Wagner wrote: > Register the PdmApplication handle in a SharedStateRegistry and pass > it to the REST server config via with_shared_state(), so API handlers > can request it through the State extractor instead of This is outdated. Should probably read `#[state] app: PdmApplication` instead. > reaching for context::pdm_application() or other globals directly. > > Signed-off-by: Lukas Wagner > --- > cli/admin/src/main.rs | 10 ++++++++-- > server/src/bin/proxmox-datacenter-api/main.rs | 15 ++++++++++----- > .../src/bin/proxmox-datacenter-privileged-api.rs | 15 ++++++++++----- > 3 files changed, 28 insertions(+), 12 deletions(-) [snip]