Re: [pve-devel] [PATCH manager v2] ui: pool create: allow selecting parent pool via selector

["Jakob Klocker" <j.klocker@proxmox.com>]

Thanks for the patch.

Tested on top of current master. Went through:

- creating a top-level pool (no parent selected) -- submits the plain name
- creating child and grandchild pools via the selector (`a/b`, `a/b/c`)
- the name field rejects slashes, preventing pool creation
- selector is hidden in edit mode
- adding a child under parents with max depth shows an error
- checking that `parentPool` isn't submited

Not touched, but made sure it still works:

- Permissions -- gave a user rights to `a/b`, confirmed it can't edit `a`
- can't remove a parent while it still has children

Everything works as expected.

One thing that _could_ be added: hiding parents already at max
depth (3), since children can't be created under them. Though one 
could argue the current behavior -- keeping them and showing the
correct error -- is better, so users aren't confused about why those
pools are missing.

Code looks good to me as well, consider this:

Reviewed-by: Jakob Klocker <j.klocker@proxmox.com>
Tested-by: Jakob Klocker <j.klocker@proxmox.com>

On Fri Jan 23, 2026 at 8:42 AM CET, Dominik Csapak wrote:
> instead of having to type out the full path, e.g. 'foo/bar/baz',
> show a 'pool selector' to select the parent pool.
>
> Forbid using slashes in the name field so it's not possible to specify
> the structure with both the name and parent pool field.
>
> This makes creating nested pools more obvious and easier.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> changes from v1:
> * always delete 'parentPool' from values so we don't accidentally submit it
> * only consider parentPool if it's a non-empty string
> * add regex to the namefield to disallow slashes
> * add emptyText to the poolselector
>
>  www/manager6/dc/PoolEdit.js | 52 +++++++++++++++++++++++++++----------
>  1 file changed, 39 insertions(+), 13 deletions(-)
>  [SNIP]