From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Jonas Theisen" <j.theisen@proxmox.com>, <pdm-devel@lists.proxmox.com>
Subject: applied: [PATCH datacenter-manager 0/2] Remove running tasks from
Date: Mon, 31 Aug 2026 13:26:04 +0200 [thread overview]
Message-ID: <DL33C1JJZRIK.BHFZICLMIVWI@proxmox.com> (raw)
In-Reply-To: <20260828155110.563237-1-j.theisen@proxmox.com>
On Fri Aug 28, 2026 at 5:49 PM CEST, Jonas Theisen wrote:
> This patch series fixes issues with filtering for errored tasks
> where running tasks would get wrongly displayed or returned through
> the API.
>
> The first patch is analogous to the patch suggested for PBS in [1]
> and fixes the PDM local tasks returned by the API when queried for
> errors.
>
> The second patch was added to align the behavior of tasks imported
> from PVE to the tasks from PBS or returned by PDM.
> This indirectly also fixes the issue that running PVE tasks get
> displayed in the Remote tab of PDM when filtering for errors
> while running PBS tasks got correctly filtered out.
>
> [1] https://lore.proxmox.com/pbs-devel/20260827154740.427154-1-j.theisen@proxmox.com/
>
> Jonas Theisen (2):
> api: Remove running tasks from errors output
> remote-tasks: Align fetched PVE tasks to PBS and PDM API
>
> server/src/api/nodes/tasks.rs | 1 +
> server/src/remote_tasks/refresh_task.rs | 8 +++++++-
> 2 files changed, 8 insertions(+), 1 deletion(-)
applied, thanks!
I slightly touched up the commit messages, but nothing major.
I also directly followed up with a patch for the remote-tasks API. While
you fixed the discrepancies between PBS and PVE tasks, you forgot to add
the additional condition to the remote-tasks API, so running tasks where
still included in the API response when `errors` as set.
https://git.proxmox.com/?p=proxmox-datacenter-manager.git;a=commitdiff;h=c3ca3a8179164d9773cc67cbe1a7e821ec80666c
prev parent reply other threads:[~2026-08-31 11:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 15:49 SPAM: [PATCH datacenter-manager 0/2] Remove running tasks from Jonas Theisen
2026-08-28 15:49 ` [PATCH datacenter-manager 1/2] api: Remove running tasks from errors output Jonas Theisen
2026-08-28 15:49 ` [PATCH datacenter-manager 2/2] remote-tasks: Align fetched PVE tasks to PBS and PDM API Jonas Theisen
2026-08-31 11:26 ` Lukas Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DL33C1JJZRIK.BHFZICLMIVWI@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=j.theisen@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.