From: "Jakob Klocker" <j.klocker@proxmox.com>
To: "Dominik Csapak" <d.csapak@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH manager v2] fix #7896: ui: qemu: show effective machine version for Windows guests
Date: Mon, 31 Aug 2026 10:42:32 +0200 [thread overview]
Message-ID: <DL2ZUUAT09Q8.1FYTCZFO1IKY1@proxmox.com> (raw)
In-Reply-To: <da240c9d-701f-45f5-96f6-88ee6a967726@proxmox.com>
On Mon Aug 31, 2026 at 10:03 AM CEST, Dominik Csapak wrote:
> ok i misunderstood what you meant from the comment, i get it now and
> could reproduce the misbehavior with the lines deleted.
> (i simply looked for a different thing)
>
> there is a much easier method instead of manipulating the value itself
> and notifying the viewmodel:
>
> since both the effectiveVersion field and the hint are only modified
> once, we don't need to use the viewmodel here at all?
>
> just have the field value set via the normal 'value' object
> but set 'submitValue: false' so it does not get submitted on
> clicking ok. (the setValue parent handler then calls resetOriginal value
> anyway)
>
> same for the hint, we can show/hide it in the setValue method, but
> don't have to use the viewmodel for it.
>
> In general the viewmodel is only really helpful if we change their
> values dynamically while the user has the editor open
> which isn't the case for the 'setValue' method (this is only
> called once on opening)
Thanks for the detailed explanation, makes a lot more sense
implementing it that way! As you mentioned, viewmodel isn't necessary
here -- not sure why I opted for it. I'll send a revision using the
'value' approach.
next prev parent reply other threads:[~2026-08-31 8:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 13:01 [PATCH manager v2] fix #7896: ui: qemu: show effective machine version for Windows guests Jakob Klocker
2026-08-26 8:36 ` Dominik Csapak
2026-08-31 7:11 ` Jakob Klocker
2026-08-31 8:03 ` Dominik Csapak
2026-08-31 8:42 ` Jakob Klocker [this message]
2026-08-31 9:48 ` superseded: " Jakob Klocker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DL2ZUUAT09Q8.1FYTCZFO1IKY1@proxmox.com \
--to=j.klocker@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.