all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Thomas Ellmenreich" <t.ellmenreich@proxmox.com>
To: "Nicolas Frey" <n.frey@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH proxmox-offline-mirror 0/3] use proxmox-pgp crate to replace verifier helper module
Date: Mon, 31 Aug 2026 10:18:54 +0200	[thread overview]
Message-ID: <DL2ZCQON5YS0.3D29PJ7SGEI04@proxmox.com> (raw)
In-Reply-To: <20260722142234.309937-1-n.frey@proxmox.com>

Deduplication is always good. ;) Compared the removed to the new code,
although its differently structured, looks to be functionally the same.

Reviewed-by: Thomas Ellmenreich <t.ellmenreich@proxmox.com>

On Wed Jul 22, 2026 at 4:22 PM CEST, Nicolas Frey wrote:
> As proxmox-pgp crate is now available, use it here and get rid of the
> verifier module.
>
> Also fixed two lifetime related clippy lints in the first patch.
>
> Changes since v1 (thanks @Erik!):
> * correctly order imports in config.rs
> * add migration context to the commit message, stating
>   no functional change was intended
>
> proxmox-offline-mirror:
>
> Nicolas Frey (3):
>   clippy: elide redundant lifetimes
>   use proxmox-pgp crate to replace verifier helper module
>   verifier: remove module
>
>  Cargo.toml                               |   1 +
>  src/bin/proxmox-offline-mirror-helper.rs |   2 +-
>  src/config.rs                            |  33 +----
>  src/helpers/mod.rs                       |   3 -
>  src/helpers/verifier.rs                  | 163 -----------------------
>  src/medium.rs                            |   2 +-
>  src/mirror.rs                            |   7 +-
>  7 files changed, 7 insertions(+), 204 deletions(-)
>  delete mode 100644 src/helpers/verifier.rs
>
>
> Summary over all repositories:
>   7 files changed, 7 insertions(+), 204 deletions(-)
>
> --
> Generated by murpp 0.12.0





  parent reply	other threads:[~2026-08-31  8:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22 14:22 [PATCH proxmox-offline-mirror 0/3] use proxmox-pgp crate to replace verifier helper module Nicolas Frey
2026-07-22 14:22 ` [PATCH proxmox-offline-mirror 1/3] clippy: elide redundant lifetimes Nicolas Frey
2026-07-22 14:22 ` [PATCH proxmox-offline-mirror 2/3] use proxmox-pgp crate to replace verifier helper module Nicolas Frey
2026-07-22 14:22 ` [PATCH proxmox-offline-mirror 3/3] verifier: remove module Nicolas Frey
2026-07-22 14:24 ` [PATCH proxmox-offline-mirror 0/3] use proxmox-pgp crate to replace verifier helper module Nicolas Frey
2026-08-31  8:18 ` Thomas Ellmenreich [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-02-26 11:12 Nicolas Frey
2026-04-03 13:35 ` Nicolas Frey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DL2ZCQON5YS0.3D29PJ7SGEI04@proxmox.com \
    --to=t.ellmenreich@proxmox.com \
    --cc=n.frey@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal