Re: [PATCH datacenter-manager] api: remote: add permission check for metric collection RRD endpoint

["Thomas Ellmenreich" <t.ellmenreich@proxmox.com>]

Thanks for sending in this patch as well!

Reviewed-by: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
Tested-by Thomas Ellmenreich <t.ellmenreich@proxmox.com>

On Fri Aug 28, 2026 at 5:25 PM CEST, Shan Shaji wrote:
> The /remote/{id}/rrddata endpoint didn't had the access parameter
> defined inside the API macro. This resulted in a
> "403: permission check failed" error even though the user
> was assigned the Administrator role on the / ACL path.
>
> Reported-by: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
>  server/src/api/remotes/mod.rs | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/server/src/api/remotes/mod.rs b/server/src/api/remotes/mod.rs
> index 5c9fdccf..d6f512f6 100644
> --- a/server/src/api/remotes/mod.rs
> +++ b/server/src/api/remotes/mod.rs
> @@ -625,7 +625,11 @@ impl DataPoint for RemoteDatapoint {
>          items: {
>              type: RemoteDatapoint,
>          }
> -    }
> +    },
> +    access: {
> +        permission: &Permission::Privilege(&["resource", "{id}"], PRIV_RESOURCE_AUDIT, false),
> +        description: "Requires `Resource.Audit` privilege on `/resource/{id}`."
> +    },
>  )]
>  /// Read metric collection RRD data.
>  fn get_per_remote_rrd_data(