From: "Thomas Ellmenreich" <t.ellmenreich@proxmox.com>
To: "Arthur Bied-Charreton" <a.bied-charreton@proxmox.com>,
<pve-devel@lists.proxmox.com>
Subject: Re: [PATCH proxmox] sys: fs: re-export nix types used in file creation API
Date: Fri, 28 Aug 2026 16:55:42 +0200 [thread overview]
Message-ID: <DL0NWWZ32J31.2P3FKAZ1G1G27@proxmox.com> (raw)
In-Reply-To: <20260715115447.332954-1-a.bied-charreton@proxmox.com>
I think this change makes sense. I noticed that fs/mod.rs contains a few
uses of `stat::Mode`, which could now be replaced with just `Mode`. Not
sure if that is wanted, though.
Reviewed-by: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
On Wed Jul 15, 2026 at 1:54 PM CEST, Arthur Bied-Charreton wrote:
> Several public helpers in proxmox-sys::fs take nix types in their
> signatures: Mode, Uid and Gid for CreateOptions and fchown() and OFlag
> for atomic_open_or_create_file(). Until now, this forced consumers to
> pull in nix explicitly just to call/instantiate them.
>
> Re-export those types from proxmox-sys::fs so they can be imported from
> there directly.
>
> Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
[snip]
> use nix::sys::stat;
> -use nix::unistd::{Gid, Uid};
> +pub use nix::sys::stat::Mode;
> +pub use nix::unistd::{Gid, Uid};
> use std::os::unix::io::{AsRawFd, RawFd};
>
> #[cfg(feature = "acl")]
prev parent reply other threads:[~2026-08-28 14:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 11:54 [PATCH proxmox] sys: fs: re-export nix types used in file creation API Arthur Bied-Charreton
2026-08-28 14:55 ` Thomas Ellmenreich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DL0NWWZ32J31.2P3FKAZ1G1G27@proxmox.com \
--to=t.ellmenreich@proxmox.com \
--cc=a.bied-charreton@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.