From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 0F4C11FF0DF for ; Fri, 28 Aug 2026 15:24:40 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id A6927214E0; Fri, 28 Aug 2026 15:24:39 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 28 Aug 2026 15:24:34 +0200 Message-Id: Subject: Re: [PATCH datacenter-manager v3 0/9] refactor and partially fix #7371 From: "Lukas Wagner" To: "Dominik Csapak" , X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260821123201.3035643-1-d.csapak@proxmox.com> In-Reply-To: <20260821123201.3035643-1-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787923465383 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.554 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: KZX55GDEDFODSM446TJWQFY2MY3QEORM X-Message-ID-Hash: KZX55GDEDFODSM446TJWQFY2MY3QEORM X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri Aug 21, 2026 at 2:30 PM CEST, Dominik Csapak wrote: > the first 6 patches are pure refactors and should not change anything > user visible, could be applied independently. > > patch 7-9 partially fix #7371 by showing the HA maintenance status > of PVE nodes in various places. > LGTM in general, see individual patches for one minor nit and one potential followup Tested-by: Lukas Wagner Reviewed-by: Lukas Wagner