Re: [PATCH datacenter-manager v3 8/9] ui: pve: node selector: show maintenance badge with node name

["Lukas Wagner" <l.wagner@proxmox.com>]

On Fri Aug 21, 2026 at 2:30 PM CEST, Dominik Csapak wrote:
>          columns.push(
>              DataTableColumn::new(tr!("Memory Usage"))
> -                .render(
> -                    |entry: &ClusterNodeIndexResponse| match (entry.mem, entry.maxmem) {
> -                        (Some(mem), Some(maxmem)) => {
> -                            html! {format!("{:.2}%", 100.0 * mem as f64 / maxmem as f64)}
> -                        }
> -                        _ => html! {},
> -                    },
> -                )
> -                .sorter(
> -                    |a: &ClusterNodeIndexResponse, b: &ClusterNodeIndexResponse| a.mem.cmp(&b.mem),
> -                )
> +                .render(|entry: &PveNodeResource| {
> +                    // don't show values when the node isn't online or when it's non sensible
> +                    if entry.maxmem == 0 || entry.status != "online" {
> +                        return html! {};
> +                    }
> +                    html! {format!("{:.2}%", 100.0 * entry.mem as f64 / entry.maxmem as f64)}
> +                })
> +                .sorter(|a: &PveNodeResource, b: &PveNodeResource| a.mem.cmp(&b.mem))

Pre-existing, so material for a follow-up patch, but I think this sorter
should probably sort based on the shown percentage, not the absolute
value?

Otherwise sorting could pretty much appear random to the user, if the
amount of total memory differs per node?

>                  .into(),
>          );
>      }