From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 3A7571FF0DF for ; Fri, 28 Aug 2026 13:12:47 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id EA3D0214DD; Fri, 28 Aug 2026 13:12:46 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 28 Aug 2026 13:12:43 +0200 Message-Id: Subject: Re: [PATCH datacenter-manager 15/16] ui: auto-installer: wizard: add checkbox to add target as new remote From: "Lukas Wagner" To: "Christoph Heiss" , "Lukas Wagner" X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260731143910.936881-1-c.heiss@proxmox.com> <20260731143910.936881-16-c.heiss@proxmox.com> In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787915554416 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.562 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QHTITND6H5UZZQFV5C3UOQDDQJ6GU66E X-Message-ID-Hash: QHTITND6H5UZZQFV5C3UOQDDQJ6GU66E X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pdm-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon Aug 17, 2026 at 2:00 PM CEST, Christoph Heiss wrote: >>> diff --git a/ui/src/remotes/auto_installer/prepared_answer_form.rs b/ui= /src/remotes/auto_installer/prepared_answer_form.rs >>> index 6ee4b15a..e6eace8f 100644 >>> --- a/ui/src/remotes/auto_installer/prepared_answer_form.rs >>> +++ b/ui/src/remotes/auto_installer/prepared_answer_form.rs >>> @@ -985,6 +985,13 @@ pub fn render_auth_form( >>> .tip(tr!("Optional certificate fingerprint")) >>> .value(config.post_hook_cert_fp.clone()), >>> ) >>> + .with_field( >>> + tr!("Provision As New Remote"), >>> + Checkbox::new() >>> + .name("post-hook-add-as-remote") >>> + .tip(tr!("Only available for Virtual Environment and B= ackup Server. Add the target host as new remote to this Datacenter Manager = instance.")) >> >> In other words, available for all products PDM currently supports? I >> think you could leave out the tooltip, this might actually confuse >> users. > > Yes. Thought I state it explicitly, since the auto-installer can be used > for PMG and PDM as well. Oh right, I did not really consider it from this angle, sorry. In this case it of course makes some sense to add the note. It's probably not super important tho, I'd really imagine that using PDM to auto-install *other* PDM instances and PMG instances is a pretty niche use case. > > But I see that this is also kind of implied, that it will only work for > products which are (currently) supported by PDM. > >> >>> + .default(config.post_hook_add_as_remote), >>> + ) >>> .with_large_custom_child( >>> Container::from_tag("p") >>> .key("post-hook-hint")