From: "Nicolas Frey" <n.frey@proxmox.com>
To: "Dominik Csapak" <d.csapak@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH manager v2 0/4] fix #7801: ui: warn about problematic virtio versions on iso select
Date: Thu, 27 Aug 2026 08:57:29 +0200 [thread overview]
Message-ID: <DKZJ47ZJ83JN.33HBKI0L6KHMM@proxmox.com> (raw)
In-Reply-To: <81015da8-5e46-4adc-8c0e-73794bb6ea79@proxmox.com>
On Thu Aug 27, 2026 at 8:14 AM CEST, Dominik Csapak wrote:
> high level question: could it make sense to have this
> warning also on the backend, e.g. in the start task?
>
> that way a user only using the cli/api would also see it, not
> only the ui users.
>
> if that makes sense, we might want to keep a list
> of versions on the backend and expose it via the api
> for the gui?
I think both of these points make sense to implement, I can add it in the
next revision
>
> on the backend we could even match the sha256 sum or something like
> that (if that's not too much of a performance hit on start) to
> check if it's really the right version
>
while I guess this is a better heuristic to check against instead of
just relying on the filename, I think unless performing the sha256
sum once and caching it, it would be too much of an unnecessary
performance hit.
[snip]
prev parent reply other threads:[~2026-08-27 6:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 7:49 [PATCH manager v2 0/4] fix #7801: ui: warn about problematic virtio versions on iso select Nicolas Frey
2026-08-26 7:49 ` [PATCH pve-manager v2 1/4] ui: iso selector: add option to warn about virtio versions with issues Nicolas Frey
2026-08-26 11:44 ` Fiona Ebner
2026-08-26 13:28 ` Nicolas Frey
2026-08-26 7:49 ` [PATCH pve-manager v2 2/4] ui: cd edit: add `warnVirtio` option to pass to iso selector Nicolas Frey
2026-08-26 7:49 ` [PATCH pve-manager v2 3/4] partially fix #7801: ui: ospanel: warn about problematic virtio versions Nicolas Frey
2026-08-26 7:49 ` [PATCH pve-manager v2 4/4] partially fix #7801: ui: hardware view: " Nicolas Frey
2026-08-26 11:44 ` Fiona Ebner
2026-08-26 13:38 ` Nicolas Frey
2026-08-26 14:09 ` Fiona Ebner
2026-08-27 6:14 ` [PATCH manager v2 0/4] fix #7801: ui: warn about problematic virtio versions on iso select Dominik Csapak
2026-08-27 6:57 ` Nicolas Frey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DKZJ47ZJ83JN.33HBKI0L6KHMM@proxmox.com \
--to=n.frey@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.