From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pdm-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40])
	by lore.proxmox.com (Postfix) with ESMTPS id 3C5D81FF0C1
	for <inbox@lore.proxmox.com>; Wed, 26 Aug 2026 16:30:09 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 679B42133B;
	Wed, 26 Aug 2026 16:30:08 +0200 (CEST)
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Wed, 26 Aug 2026 16:30:04 +0200
Message-Id: <DKYY47JFJM77.1WV40A70LJ4QR@proxmox.com>
From: =?utf-8?q?Michael_K=C3=B6ppl?= <m.koeppl@proxmox.com>
To: "Lukas Wagner" <l.wagner@proxmox.com>, <pdm-devel@lists.proxmox.com>
Subject: Re: [PATCH datacenter-manager v2 18/20] api: subscriptions: use
 PdmApplication instead of globals
X-Mailer: aerc 0.22.0
References: <20260820145220.418032-1-l.wagner@proxmox.com>
 <20260820145220.418032-19-l.wagner@proxmox.com>
In-Reply-To: <20260820145220.418032-19-l.wagner@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1787754597031
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.953 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: EQTVFNPE3ZDHMF2JAVHMTTTMNKJYXZKK
X-Message-ID-Hash: EQTVFNPE3ZDHMF2JAVHMTTTMNKJYXZKK
X-MailFrom: m.koeppl@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox Datacenter Manager development discussion
 <pdm-devel.lists.proxmox.com>
List-Help: <mailto:pdm-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pdm-devel-owner@lists.proxmox.com>
List-Post: <mailto:pdm-devel@lists.proxmox.com>
List-Subscribe: <mailto:pdm-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pdm-devel-leave@lists.proxmox.com>

On Thu Aug 20, 2026 at 4:52 PM CEST, Lukas Wagner wrote:

[snip]

> +use crate::api_cache::ApiCache;
> +use crate::context::PdmApplication;
>  use crate::metric_collection::top_entities;
>  use crate::{api_cache, connection, views};
> =20
> @@ -686,6 +688,7 @@ pub async fn get_subscription_status(
>      verbose: bool,
>      view: Option<String>,
>      rpcenv: &mut dyn RpcEnvironment,
> +    app: State<PdmApplication>,
>  ) -> Result<Vec<RemoteSubscriptions>, Error> {
>      let (remotes_config, _) =3D pdm_config::remotes::config()?;

Wouldn't it make sense to use

    let (remotes_config, _) =3D app.remote_config().read()?;

here as well?

> =20
> @@ -711,10 +714,11 @@ pub async fn get_subscription_status(
>          }
> =20
>          let view =3D view.clone();
> +        let app_clone =3D app.clone();
> =20
>          let future =3D async move {
>              let (node_status, error) =3D
> -                match get_subscription_info_for_remote(&remote, max_age)=
.await {
> +                match get_subscription_info_for_remote(&app_clone, &remo=
te, max_age).await {
>                      Ok(mut node_status) =3D> {
>                          node_status.retain(|node, _| {
>                              if let Some(view) =3D &view {

[snip]