From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id F233F1FF0C1 for ; Wed, 26 Aug 2026 15:38:10 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 858C421347; Wed, 26 Aug 2026 15:38:10 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 26 Aug 2026 15:38:05 +0200 Message-Id: Subject: Re: [PATCH pve-manager v2 4/4] partially fix #7801: ui: hardware view: warn about problematic virtio versions From: "Nicolas Frey" To: "Fiona Ebner" , X-Mailer: aerc 0.20.0 References: <20260826074935.78437-1-n.frey@proxmox.com> <20260826074935.78437-5-n.frey@proxmox.com> In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787751477623 X-SPAM-LEVEL: Spam detection results: 0 AWL 1.353 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: U6CRMI47GWMYZ3PMAFQMFLIPI5MO24XV X-Message-ID-Hash: U6CRMI47GWMYZ3PMAFQMFLIPI5MO24XV X-MailFrom: n.frey@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed Aug 26, 2026 at 1:44 PM CEST, Fiona Ebner wrote: > Am 26.08.26 um 9:49 AM schrieb Nicolas Frey: >> based on whether the ostype is windows or not. extends the >> `editorFactory` to allow extraOptions to be a callback to allow for lazy >> evaluation. this is needed as 'ostype' is not yet instantiated when >> eagerly evaluating. >> >> Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=3D7801 >> Signed-off-by: Nicolas Frey >> --- >> changes since v1: >> * actually lazily evaluate the ostype by putting it in >> the function body that gets returned (i.e. the factory) >> * add missing warnVirtio to commonOpts >> >> www/manager6/qemu/HardwareView.js | 8 +++++--- >> 1 file changed, 5 insertions(+), 3 deletions(-) >> >> diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/Hardw= areView.js >> index e6c02299..9e900746 100644 >> --- a/www/manager6/qemu/HardwareView.js >> +++ b/www/manager6/qemu/HardwareView.js >> @@ -436,6 +436,7 @@ Ext.define('PVE.qemu.HardwareView', { >> listeners: { >> destroy: () =3D> me.reload(), >> }, >> + warnVirtio: PVE.Utils.is_windows(me.getObjectValue('ost= ype')), > > Seems a bit out of place in the commonOpts. Can't we do this more > locally in the definition below? Might need splitting out like the > efidisk_menuitem? > doesn't efidisk_menuitem just apply to the "Add" dropdown menu? the commonO= pts are IMO not ideal, but there is no option to pass in any additional options= : ``` if (Ext.isString(editor)) { Ext.create(editor, commonOpts); } ``` where the `CDEdit` editor is determined (in `run_editor`) like so: ``` if (rowdef.isOnStorageBus) { let value =3D me.getObjectValue(rec.data.key, '', true); if (isCloudInitKey(value)) { return; } else if (value.match(/media=3Dcdrom/)) { editor =3D 'PVE.qemu.CDEdit'; } else if (!diskCap) { return; } } ``` I'd have to rewrite a bunch of stuff here to allow for that and I'm not sure it's worth the hassle here. what do you think? >> }; >> >> if (Ext.isString(editor)) { >> @@ -805,7 +806,6 @@ Ext.define('PVE.qemu.HardwareView', { >> }; >> >> let editorFactory =3D (classPath, extraOptions) =3D> { >> - extraOptions =3D extraOptions || {}; >> return () =3D> >> Ext.create(`PVE.qemu.${classPath}`, { >> autoShow: true, >> @@ -816,7 +816,7 @@ Ext.define('PVE.qemu.HardwareView', { >> }, >> isAdd: true, >> isCreate: true, >> - ...extraOptions, >> + ...(Ext.isFunction(extraOptions) ? extraOptions() := extraOptions || {}), > > This is rather hacky too. > do you mean the way it's written with a ternary or generally the lazy evalu= ation? >> }); >> }; >> >> @@ -847,7 +847,9 @@ Ext.define('PVE.qemu.HardwareView', { >> text: gettext('CD/DVD Drive'), >> iconCls: 'pve-itype-icon-cdrom', >> disabled: !caps.vms['VM.Config.CDROM'], >> - handler: editorFactory('CDEdit'), >> + handler: editorFactory('CDEdit', () =3D= > ({ >> + warnVirtio: PVE.Utils.is_windows(me= .getObjectValue('ostype')), >> + })), >> }, >> { >> text: gettext('Network Device'), >> -- >> 2.47.3 >> >> >>