From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id D63281FF0C1 for ; Wed, 26 Aug 2026 15:28:08 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 693DE21443; Wed, 26 Aug 2026 15:28:07 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 26 Aug 2026 15:28:02 +0200 Message-Id: Subject: Re: [PATCH pve-manager v2 1/4] ui: iso selector: add option to warn about virtio versions with issues From: "Nicolas Frey" To: "Fiona Ebner" , X-Mailer: aerc 0.20.0 References: <20260826074935.78437-1-n.frey@proxmox.com> <20260826074935.78437-2-n.frey@proxmox.com> <3cec4b70-3e06-434d-aa8f-0c9b07252de0@proxmox.com> In-Reply-To: <3cec4b70-3e06-434d-aa8f-0c9b07252de0@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787750874366 X-SPAM-LEVEL: Spam detection results: 0 AWL 1.394 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: SA6ZVYVZW23SHRBQD3S5GDWTAF6XKDNO X-Message-ID-Hash: SA6ZVYVZW23SHRBQD3S5GDWTAF6XKDNO X-MailFrom: n.frey@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed Aug 26, 2026 at 1:44 PM CEST, Fiona Ebner wrote: > Am 26.08.26 um 9:49 AM schrieb Nicolas Frey: >> based on the known issues as seen on the wiki. If warnVirtio is true, >> the filename is matched against "virtio-win-x.x.x.iso" and checks >> whether the version number in the filename is in any "from - to" version >> range in `virtioIssues`. >> >> Signed-off-by: Nicolas Frey >> --- >> changes since v1: >> * use single gettext call for warning message >> * remove the detailed hints about which version to switch to, >> instead rely on the link to the wiki >> >> www/manager6/form/IsoSelector.js | 70 +++++++++++++++++++++++++++++++- >> 1 file changed, 68 insertions(+), 2 deletions(-) >> >> diff --git a/www/manager6/form/IsoSelector.js b/www/manager6/form/IsoSel= ector.js >> index b2d94ed3..ba7b6953 100644 >> --- a/www/manager6/form/IsoSelector.js >> +++ b/www/manager6/form/IsoSelector.js >> @@ -10,6 +10,7 @@ Ext.define('PVE.form.IsoSelector', { >> >> nodename: undefined, >> insideWizard: false, >> + warnVirtio: false, > > Nit: I'd use a slightly more explicit name "warnVirtioWin" and similarly > for other names below ack > >> labelWidth: undefined, >> labelAlign: 'right', [snip] >> + let atag =3D `> + href=3D"https://pve.proxmox.com/wiki/Windows_VirtIO_Drivers= #Known_issues" > > Typo: the i should be capitalized, i.e. "#Known_Issues" > will change in next revision, good catch! >> + target=3D"_blank">${gettext('known issues')}`; >> + >> + warningBox.setHtml( >> + ' ' + >> + Ext.String.format( >> + gettext( >> + 'Version {0} of the VirtIO drivers is known to = cause issues. See {1} for more details.', >> + ), >> + version, >> + atag, >> + ), >> + ); >> + }, >> + >> referenceHolder: true, >> >> items: [ >> @@ -105,10 +163,18 @@ Ext.define('PVE.form.IsoSelector', { >> }, >> allowBlank: false, >> listeners: { >> - change: function () { >> - this.up('pveIsoSelector').checkChange(); >> + change: function (_field, value) { >> + let selector =3D this.up('pveIsoSelector'); >> + if (selector.warnVirtio) { >> + selector.checkVirtioVersion(value); >> + } >> + selector.checkChange(); >> }, >> }, >> }, >> + { >> + xtype: 'displayfield', > > Please use > userCls: 'pmx-hint', > like we do for other warnings. And it should start out as hidden, > otherwise there is suddenly new spacing below all ISO selectors. > Ah I didn't notice that, sorry. Will do in a v3, thanks! >> + reference: 'virtioWarning', >> + }, >> ], >> }); >> -- >> 2.47.3 >> >> >>