From: "Michael Köppl" <m.koeppl@proxmox.com>
To: "Jakob Klocker" <j.klocker@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH pve-docs 1/2] qm: pci passthrough: replace obsolete module loading procedure
Date: Tue, 25 Aug 2026 15:04:09 +0200 [thread overview]
Message-ID: <DKY1NVPIDFDE.2PDCA78E4DDC3@proxmox.com> (raw)
In-Reply-To: <20260825114642.278296-2-j.klocker@proxmox.com>
Quickly discussed this with Jakob off-list, as I felt that a reference
in the commit message to e.g. the Debian documentation that mentions
that the file is now obsolete would have been nice. A quick search did
not really turn up anything, though. A comment in /etc/modules notes
that it's obsolete, though, so this seems fine IMO.
Reviewed-by: Michael Köppl <m.koeppl@proxmox.com>
On Tue Aug 25, 2026 at 1:46 PM CEST, Jakob Klocker wrote:
> Loading modules by adding them to `/etc/modules` is obsolete and has
> been replaced by `/etc/modules-load.d/`.
>
> Signed-off-by: Jakob Klocker <j.klocker@proxmox.com>
> ---
> qm-pci-passthrough.adoc | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/qm-pci-passthrough.adoc b/qm-pci-passthrough.adoc
> index 00d9478..a188005 100644
> --- a/qm-pci-passthrough.adoc
> +++ b/qm-pci-passthrough.adoc
> @@ -98,8 +98,8 @@ to the xref:sysboot_edit_kernel_cmdline[kernel commandline].
>
> .Kernel Modules
>
> -You have to make sure the following modules are loaded. This can be achieved by
> -adding them to `'/etc/modules''.
> +Make sure the following modules are loaded by adding them to a file under
> +`'/etc/modules-load.d/'`, for example `'/etc/modules-load.d/vfio.conf'`:
>
> .Mediated devices passthrough
> [NOTE]
> @@ -467,8 +467,8 @@ with 5th, 6th and 7th generation Intel Core Processors, as well as E3 v4, E3
> v5 and E3 v6 Xeon Processors.
>
> To enable it for Intel Graphics, you have to make sure to load the module
> -'kvmgt' (for example via `/etc/modules`) and to enable it on the
> -xref:sysboot_edit_kernel_cmdline[Kernel commandline] and add the following parameter:
> +'kvmgt' (for example via `/etc/modules-load.d/`) and to enable it on the
> +xref:sysboot_edit_kernel_cmdline[kernel commandline] and add the following parameter:
>
> ----
> i915.enable_gvt=1
next prev parent reply other threads:[~2026-08-25 13:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 11:46 [PATCH docs 0/2] qm: pci passthrough: various fixes and clarifications Jakob Klocker
2026-08-25 11:46 ` [PATCH pve-docs 1/2] qm: pci passthrough: replace obsolete module loading procedure Jakob Klocker
2026-08-25 13:04 ` Michael Köppl [this message]
2026-08-25 11:46 ` [PATCH pve-docs 2/2] qm: pci passthrough: fix grammar and spelling Jakob Klocker
2026-08-25 12:46 ` Michael Köppl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DKY1NVPIDFDE.2PDCA78E4DDC3@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=j.klocker@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.