From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 7F6E61FF0B7 for ; Tue, 25 Aug 2026 14:46:48 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id CCD39215B2; Tue, 25 Aug 2026 14:46:47 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 25 Aug 2026 14:46:42 +0200 Message-Id: From: =?utf-8?q?Michael_K=C3=B6ppl?= To: "Jakob Klocker" , Subject: Re: [PATCH pve-docs 2/2] qm: pci passthrough: fix grammar and spelling X-Mailer: aerc 0.22.0 References: <20260825114642.278296-1-j.klocker@proxmox.com> <20260825114642.278296-3-j.klocker@proxmox.com> In-Reply-To: <20260825114642.278296-3-j.klocker@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787661971475 X-SPAM-LEVEL: Spam detection results: 0 AWL 1.076 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: G2AN2CGTUS7OSKRGYUHJPVKC64URZPA6 X-Message-ID-Hash: G2AN2CGTUS7OSKRGYUHJPVKC64URZPA6 X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: 2 nits inline, other than that I like the changes! Reviewed-by: Michael K=C3=B6ppl On Tue Aug 25, 2026 at 1:46 PM CEST, Jakob Klocker wrote: [snip] =20 > @@ -300,13 +300,14 @@ VM Configuration > When passing through a GPU, the best compatibility is reached when using > 'q35' as machine type, 'OVMF' ('UEFI' for VMs) instead of SeaBIOS and PC= Ie > instead of PCI. Note that if you want to use 'OVMF' for GPU passthrough,= the > -GPU needs to have an UEFI capable ROM, otherwise use SeaBIOS instead. To= check if > +GPU needs to have a UEFI-capable ROM, otherwise use SeaBIOS instead. To = check if > the ROM is UEFI capable, see the > https://pve.proxmox.com/wiki/PCI_Passthrough#How_to_know_if_a_graphics_c= ard_is_UEFI_.28OVMF.29_compatible[PCI Passthrough Examples] > wiki. > =20 > -Furthermore, using OVMF, disabling vga arbitration may be possible, redu= cing the > -amount of legacy code needed to be run during boot. To disable vga arbit= ration: > +Furthermore, when using OVMF, you may be able to disable VGA arbitration= , nit: might just be me, but to me "you may be able to..." reads like the the person now has the ability to do so. Maybe something like "VGA arbitration can potentially be disabled" would be more fitting. > +which reduces the amount of legacy code that needs to run at boot. > +To disable VGA arbitration: > =20 > ---- > echo "options vfio-pci ids=3D, disable_vga=3D1" >= /etc/modprobe.d/vfio.conf > @@ -335,17 +336,17 @@ or by adding a line to the VM configuration file: [snip] > +a single device to provide multiple 'VFs' (**V**irtual **F**unctions) to= the > +system. Each of those 'VFs' can be used in a different VM, with full har= dware > +features and also better performance and lower latency than software-vir= tualized > +devices. > =20 > -Currently, the most common use case for this are NICs (**N**etwork > +Currently, the most common use case for this is NICs (**N**etwork nit: both versions read a bit awkward to me, even though the second is grammatically correct. Maybe something like "Currently, the most common use case for this is with NICs" could work. > **I**nterface **C**ard) with SR-IOV support, which can provide multiple = VFs per > -physical port. This allows using features such as checksum offloading, e= tc. to > -be used inside a VM, reducing the (host) CPU overhead. > +physical port. This allows features such as checksum offloading to be us= ed=20 > +inside a VM, reducing the (host) CPU overhead. > =20 > Host Configuration [snip]