From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pdm-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40])
	by lore.proxmox.com (Postfix) with ESMTPS id 3B9681FF0B2
	for <inbox@lore.proxmox.com>; Mon, 24 Aug 2026 15:49:07 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id CF76E2141D;
	Mon, 24 Aug 2026 15:49:06 +0200 (CEST)
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Mon, 24 Aug 2026 15:48:59 +0200
Message-Id: <DKX7ZNIN286G.3EXXMSVO6MHHX@proxmox.com>
To: "Dominik Csapak" <d.csapak@proxmox.com>, "Lukas Wagner"
 <l.wagner@proxmox.com>, <pdm-devel@lists.proxmox.com>
Subject: Re: [PATCH datacenter-manager v2 08/20] context: introduce a
 ContextFactory to build application context
From: "Lukas Wagner" <l.wagner@proxmox.com>
X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty
References: <20260820145220.418032-1-l.wagner@proxmox.com>
 <20260820145220.418032-9-l.wagner@proxmox.com>
 <38d64223-cfad-40f1-bf60-855e0214d28c@proxmox.com>
In-Reply-To: <38d64223-cfad-40f1-bf60-855e0214d28c@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1787579309228
X-SPAM-LEVEL: Spam detection results:  0
	AWL                    -0.518 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: OFCHBQQRARRTDMHEQJ6M2P2IORUOC2SA
X-Message-ID-Hash: OFCHBQQRARRTDMHEQJ6M2P2IORUOC2SA
X-MailFrom: l.wagner@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox Datacenter Manager development discussion
 <pdm-devel.lists.proxmox.com>
List-Help: <mailto:pdm-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pdm-devel-owner@lists.proxmox.com>
List-Post: <mailto:pdm-devel@lists.proxmox.com>
List-Subscribe: <mailto:pdm-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pdm-devel-leave@lists.proxmox.com>

On Mon Aug 24, 2026 at 2:33 PM CEST, Dominik Csapak wrote:
>> +    pdm_config::subscriptions::init(factory.make_subscription_key_confi=
g()?);
>> +    pdm_config::remotes::init(factory.make_remote_config()?);
>> +    // FIXME: Rather let connection use an Application context object f=
rom here
>> +    connection::init(Box::new(connection::DefaultClientFactory));
>
> here we always use the defaultclientfactory?
>
> shouldn't this here be:
>
> factory.make_client_factory()
> ?
>
> i know this is changed in the next commit anyway, but
> IMHO it make sense to keep the functionality for intermediate
> commits (so a bisect works...)
>
>

Thanks, I think this was an oopsie that happened in one of many
interactive rebase sessions; will fix it for v3.