From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id ACFEA1FF0B2 for ; Thu, 20 Aug 2026 13:08:44 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id C561C21576; Thu, 20 Aug 2026 13:08:43 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 20 Aug 2026 13:08:39 +0200 Message-Id: From: "Lukas Wagner" To: "Dominik Csapak" , Subject: Re: [PATCH datacenter-manager v2 0/9] refactor and partially fix #7371 X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260818133000.3793412-1-d.csapak@proxmox.com> In-Reply-To: <20260818133000.3793412-1-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787224094620 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.815 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BIHATQA5PHKTFY5XCPFFUANFEOU2SPTA X-Message-ID-Hash: BIHATQA5PHKTFY5XCPFFUANFEOU2SPTA X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue Aug 18, 2026 at 3:25 PM CEST, Dominik Csapak wrote: > the first 6 patches are pure refactors and should not change anything > user visible, could be applied independently. > > patch 7-9 partially fix #7371 by showing the HA maintenance status > of PVE nodes in various places. > > changes from v1: > * fixed some display problems: NaN% when maxmem was set to 0.0, > 0.0% cpu when the node was offline, fixed by not showing values for > offline nodes > * add a new patch for showing tha badge too in the node card's title > * various typo fixes > * added #[serde(default)] to the new hastate field to allow > deserialization from older versions > * some smaller fixes (left over comments, naming, etc.) > > Dominik Csapak (9): > lib: api types: add new ResourceView type and move accessors there > lib: api types: resource: add 'node' helper to ResourceView > lib: api types: add guest specific getter to ResourceView > ui: pve: factor out the pve-manager version extraction > ui: renderer: use ResourceView for rendering > ui: pve: tree: reuse `PveResource` for `PveTreeNode` > ui: pve: show ha maintenance mode for nodes > ui: pve: node selector: show maintenance badge with node name > ui: pve: node: show HA maintenance badge > > lib/pdm-api-types/src/resource.rs | 301 ++++++++++++++++++++-------- > server/src/api/resources.rs | 1 + > ui/pwt-assets | 2 +- > ui/src/dashboard/top_entities.rs | 5 +- > ui/src/guests.rs | 6 +- > ui/src/lib.rs | 23 +-- > ui/src/pve/mod.rs | 73 ++++--- > ui/src/pve/node/mod.rs | 15 +- > ui/src/pve/tree.rs | 302 ++++++++++++++--------------- > ui/src/renderer.rs | 66 ++++--- > ui/src/widget/pve_node_selector.rs | 91 +++++---- > ui/src/widget/resource_tree.rs | 11 +- > 12 files changed, 533 insertions(+), 363 deletions(-) Looks good to me. Two minor things, see patch replies for details. Tested-by: Lukas Wagner Reviewed-by: Lukas Wagner