From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id E949A1FF0EA for ; Thu, 13 Aug 2026 14:40:18 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id A115C215A8; Thu, 13 Aug 2026 14:40:18 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 13 Aug 2026 14:40:13 +0200 Message-Id: Subject: Re: [RFC datacenter-manager 1/1] fix #7135: openid auth: improve error logging From: "Nicolas Frey" To: "Thomas Ellmenreich" , X-Mailer: aerc 0.20.0 References: <20260812084615.56044-1-t.ellmenreich@proxmox.com> In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1786624796674 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.577 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust RDNS_NONE 1.274 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QVRMZN3PUP6AUTAWXFG56G232MT2J7M3 X-Message-ID-Hash: QVRMZN3PUP6AUTAWXFG56G232MT2J7M3 X-MailFrom: n.frey@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu Aug 13, 2026 at 1:02 PM CEST, Thomas Ellmenreich wrote: > Thanks for having a look ;) > > On Thu Aug 13, 2026 at 11:27 AM CEST, Nicolas Frey wrote: > > [snip] > >> Consider adding a Fixes trailer, referencing the bug like so: >> Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=3D7135 > > Ah, yes, thank you very much for pointing this out. It's not the first ti= me > I've forgotten... xC > > [snip] > >> personally I'd rather see a verbose error message than none at all > > Good to hear! > > [snip] > >> also, why the alternate formatting ("{err:#}") [0] and not just "{err}"? >> >> [0] https://doc.rust-lang.org/std/fmt/#sign0 > > I thought this error should display as much information as possible, so i= t > should print all the 'anyhow' contexts. The 'alternate' formatting with '= #' > causes 'anyhow' to display all the different contexts [1]. Had I not used > the 'alternate' formatting, the error I included would have been reduced = to: > > ``` > ... proxmox-datacenter-privileged-api[616]: could not get opneid auth url= : Request failed > ``` > > Which is also exactly what is currently sent to the client. > > [1]: https://github.com/dtolnay/anyhow/blob/bf3ed9149f4334c984c1ad252b534= 107b307078c/src/fmt.rs#L10-L15 > > [snip] Ah, thanks for the explanation! I think it might be good to include that rationale in the commit message (i.e. why we want to have such verbose logging here)