From: "Thomas Ellmenreich" <t.ellmenreich@proxmox.com>
To: "Nicolas Frey" <n.frey@proxmox.com>, <pdm-devel@lists.proxmox.com>
Subject: Re: [RFC datacenter-manager 1/1] fix #7135: openid auth: improve error logging
Date: Thu, 13 Aug 2026 13:02:08 +0200 [thread overview]
Message-ID: <DKNRJX6PZFTK.18CTY50METALZ@proxmox.com> (raw)
In-Reply-To: <DKNPJPNDC8LP.1YQIA00VIJPHR@proxmox.com>
Thanks for having a look ;)
On Thu Aug 13, 2026 at 11:27 AM CEST, Nicolas Frey wrote:
[snip]
> Consider adding a Fixes trailer, referencing the bug like so:
> Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=7135
Ah, yes, thank you very much for pointing this out. It's not the first time
I've forgotten... xC
[snip]
> personally I'd rather see a verbose error message than none at all
Good to hear!
[snip]
> also, why the alternate formatting ("{err:#}") [0] and not just "{err}"?
>
> [0] https://doc.rust-lang.org/std/fmt/#sign0
I thought this error should display as much information as possible, so it
should print all the 'anyhow' contexts. The 'alternate' formatting with '#'
causes 'anyhow' to display all the different contexts [1]. Had I not used
the 'alternate' formatting, the error I included would have been reduced to:
```
... proxmox-datacenter-privileged-api[616]: could not get opneid auth url: Request failed
```
Which is also exactly what is currently sent to the client.
[1]: https://github.com/dtolnay/anyhow/blob/bf3ed9149f4334c984c1ad252b534107b307078c/src/fmt.rs#L10-L15
[snip]
next prev parent reply other threads:[~2026-08-13 11:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 8:46 [RFC datacenter-manager 1/1] fix #7135: openid auth: improve error logging Thomas Ellmenreich
2026-08-13 9:27 ` Nicolas Frey
2026-08-13 11:02 ` Thomas Ellmenreich [this message]
2026-08-13 12:40 ` Nicolas Frey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DKNRJX6PZFTK.18CTY50METALZ@proxmox.com \
--to=t.ellmenreich@proxmox.com \
--cc=n.frey@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.