From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 459C81FF0E5 for ; Wed, 12 Aug 2026 15:41:20 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 05C65214EF; Wed, 12 Aug 2026 15:41:20 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 12 Aug 2026 15:41:14 +0200 Message-Id: Subject: Re: [PATCH proxmox{-backup,} v2 0/3] partially fix #6933: add option to specify zfs recordsize From: "Nicolas Frey" To: "Shan Shaji" , X-Mailer: aerc 0.20.0 References: <20260812110338.77010-1-s.shaji@proxmox.com> In-Reply-To: <20260812110338.77010-1-s.shaji@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1786542059646 X-SPAM-LEVEL: Spam detection results: 0 AWL 1.457 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ZJAAK6MHZTV3NZBAKBMMN3D5SDX6MPME X-Message-ID-Hash: ZJAAK6MHZTV3NZBAKBMMN3D5SDX6MPME X-MailFrom: n.frey@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed Aug 12, 2026 at 1:03 PM CEST, Shan Shaji wrote: > The option to specify the `recordsize` was previously available neither > in the UI nor in the CLI. Users had to configure it manually using the > ZFS CLI. This series adds an option for specifying the `recordsize` > through both the UI and `proxmox-backup-manager` when creating storage. > > Since adding support for editing this property at the dataset level > would require more changes, I am sending the creation related > changes first. Support for editing the property will be send > as a separate series. > > changes since v1: Thanks @Nicolas Frey > > * Patch [3/3] - Add validation function identical to the one in Javscript= to > verify if the passed recordsize is valid. If it's not valid, then the > backup manager exits without creating the pool. Earlier, even though > the recordsize format was wrong, the backup manager allowed executing > the zpool and zfs commands, which in turn created the pool with the > default(128k) recordsize, but the `zfs set` command failed with an erro= r. thanks for sending a v2! one small style nit on patch [3/3]. consider this: Reviewed-by: Nicolas Frey Tested-by: Nicolas Frey > > References: > - https://openzfs.github.io/openzfs-docs/Performance%20and%20Tuning/Workl= oad%20Tuning.html#dataset-recordsize > > proxmox-backup: > > Shan Shaji (2): > partially fix #6933: ui: storage: add option to specify zfs recordsize > partially fix #6933: bin: add option to specify ZFS recordsize > > src/api2/node/disks/zfs.rs | 14 +++++++++++-- > src/bin/proxmox_backup_manager/disk.rs | 8 ++++++-- > www/Utils.js | 28 ++++++++++++++++++++++++++ > www/window/ZFSCreate.js | 8 ++++++++ > 4 files changed, 54 insertions(+), 4 deletions(-) > > > proxmox: > > Shan Shaji (1): > pbs-api-types: zfs: define schema for recordsize > > pbs-api-types/src/zfs.rs | 68 ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 68 insertions(+) > > > Summary over all repositories: > 5 files changed, 122 insertions(+), 4 deletions(-)