Re: [PATCH qemu-server v2 2/3] add new classify_drive_file utility

["Elias Huhsovitz" <e.huhsovitz@proxmox.com>]

Good refactor.

1 small nit inline.

On Wed Aug 5, 2026 at 10:21 AM CEST, Thomas Ellmenreich wrote:
> To more easily and clearly branch off different types of drive files a
> new utility function is introduced that classifies such a drive file.
> The return options are 'none', 'cdrom', 'absolute' and 'volume'. In any
> other case the function returns 'unknown'.
>
> Signed-off-by: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
> ---
>  src/PVE/QemuServer.pm       | 29 ++++++++++++++++++-----------
>  src/PVE/QemuServer/Drive.pm | 25 +++++++++++++++++++++++++
>  2 files changed, 43 insertions(+), 11 deletions(-)
>
> diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
> index fdef20dc..0e998cbe 100644

[...]

> +# Tries to classify the drive file as either 'none', 'cdrom', 'absolute'
> +# or 'volume'. In all other cases it will return undef.

nit: Subroutine returns 'unknown' in default path.
Comments states that `undef` is returned.

> +sub classify_drive_file {
> +    my ($volid) = @_;
> +
> +    if ($volid eq 'none') {
> +        return 'none';
> +    } elsif ($volid eq 'cdrom') {
> +        return 'cdrom';
> +    } elsif ($volid =~ m|^/|) {
> +        return 'absolute';
> +    } elsif (PVE::Storage::parse_volume_id($volid, 1)) {
> +        return 'volume';
> +    }
> +
> +    return 'unknown';
> +}
> +
>  sub drive_is_cloudinit {
>      my ($drive) = @_;
>      return $drive->{file} =~ m@[:/](?:vm-\d+-)?cloudinit(?:\.$QEMU_FORMAT_RE)?$@;
> @@ -794,6 +814,11 @@ sub drive_is_cdrom {
>      return $drive && $drive->{media} && ($drive->{media} eq 'cdrom');
>  }
>  
> +sub drive_has_absolute_path {
> +    my ($drive) = @_;
> +    return classify_drive_file($drive->{file}) eq "absolute";
> +}
> +
>  sub parse_drive_interface {
>      my ($key) = @_;
>