From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 773D41FF0E1 for ; Mon, 10 Aug 2026 10:39:59 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id CE0ED21619; Mon, 10 Aug 2026 10:39:58 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 10 Aug 2026 10:39:55 +0200 Message-Id: Subject: Re: [PATCH proxmox-acme v2] fix #7749: always serialize in same order From: "Elias Huhsovitz" To: "Thomas Ellmenreich" , X-Mailer: aerc 0.20.0 References: <20260727072958.37999-1-t.ellmenreich@proxmox.com> In-Reply-To: <20260727072958.37999-1-t.ellmenreich@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1786351183616 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.899 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: IRIXRWVCMQXNHPFMMUHQXEQAOYUCX2S3 X-Message-ID-Hash: IRIXRWVCMQXNHPFMMUHQXEQAOYUCX2S3 X-MailFrom: e.huhsovitz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: `to_json()` expects a hash reference. Current options might be ignored. See comments below. On Mon Jul 27, 2026 at 9:29 AM CEST, Thomas Ellmenreich wrote: > All objects are now serialized with "canonical =3D> 1" so that the > resulting bytes are directly comparable. Perls randomized hash key > orders lead to different serialization outputs even with the same input. > > The 'tojs' function also now explicitly overrides the utf8 and canonical > options to make sure that they are always set. > > Signed-off-by: Thomas Ellmenreich > Reviewed-by: Elias Huhsovitz > --- > Serializing acme responses to json, because of perls randomized hash key = order, > would lead to unequal serialized responses if they were compared as bytes= . By > setting "canonical =3D> 1" the serializations now always have the same or= der and > can thus be compared bytewise. > > I have tested the patch against a local instance of HashiCorp Vault PKI a= nd the > EAB registration works. > > It seems that "canonical" can have performance implications when serialis= ing > larger objects, but since the objects produced in our acme client are > relatively small, I consider this acceptable. > > > src/PVE/ACME.pm | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/src/PVE/ACME.pm b/src/PVE/ACME.pm > index e6fb9c2..fb93eca 100644 > --- a/src/PVE/ACME.pm > +++ b/src/PVE/ACME.pm > @@ -64,9 +64,13 @@ sub encode($) { # acme requires 'base64url' encoding > return encode_base64url($_[0]); > } > =20 > -sub tojs($;%) { # shortcut for to_json with utf8=3D>1 > - my ($data, %data) =3D @_; > - return to_json($data, { utf8 =3D> 1, %data }); > +sub tojs($;%) { # shortcut for to_json with utf8=3D>1 and canonical=3D>1 > + my ($data, %opts) =3D @_; > + > + $opts{utf8} =3D 1; > + $opts{canonical} =3D 1; > + > + return to_json($data, %opts); should be: return to_json($data, \%opts); `to_json` expects a hash reference for optional parameters. Passing the hash causes perl to automatically expand it, effectively calling: to_json($data, utf8 =3D> 1, canonical =3D> 1); instead of to_json($data, { utf8 =3D> 1, canonical =3D> 1 }); > } > =20 > sub fromjs($) { > @@ -155,7 +159,7 @@ sub save { > } > # pretty =3D> 1 for readability > # canonical =3D> 1 to reduce churn > - file_set_contents($self->{path}, tojs($o, pretty =3D> 1, canonical = =3D> 1)); > + file_set_contents($self->{path}, tojs($o, pretty =3D> 1)); > } > =20 > # Load serialized account JSON file into $self > @@ -196,7 +200,7 @@ sub jwk { > sub jwk_thumbprint { > my ($self) =3D @_; > my $jwk =3D $self->jwk(1); # $pure =3D 1 > - return encode(sha256(tojs($jwk, canonical =3D> 1))); # canonical sor= ts > + return encode(sha256(tojs($jwk))); > } > =20 > # A key authorization string in acme is a challenge token dot-connected = with