From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 88D381FF0E6 for ; Fri, 07 Aug 2026 14:55:56 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 06F5F21551; Fri, 07 Aug 2026 14:55:56 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 07 Aug 2026 14:55:51 +0200 Message-Id: Subject: Re: [PATCH pve-storage] esxi plugin: keep uuid inside vm the same as in esxi To: "Nicolas Reinecke" , From: "Max R. Carrara" X-Mailer: aerc 0.18.2-0-ge037c095a049 References: <20260727151800.13685-1-nr@das-labor.org> In-Reply-To: <20260727151800.13685-1-nr@das-labor.org> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1786107344219 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.428 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: TLFCARDIYPP2BL7CYFUD27ZLJYDZNQLH X-Message-ID-Hash: TLFCARDIYPP2BL7CYFUD27ZLJYDZNQLH X-MailFrom: m.carrara@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon Jul 27, 2026 at 5:17 PM CEST, Nicolas Reinecke wrote: > There needs to be done some byte swapping in the first 3 parts to keep > the uuid the same. > > RegEx Group Mapping to Bytes: > $1-$4 : 1st section (4 bytes) -> Reversed to $4$3$2$1 > $5-$6 : 2nd section (2 bytes) -> Reversed to $6$5 > $7-$8 : 3rd section (2 bytes) -> Reversed to $8$7 > $9 : 4th section (2 bytes) -> Kept as-is > $10 : 5th section (6 bytes) -> Kept as-is > > Signed-off-by: Nicolas Reinecke Thanks for your patch! Have you by change filled out a CLA yet? If not, see here: https://proxmox.com/en/about/open-source/developers Once confirmed that the CLA's in, I'll have a closer look at this. - Max > --- > src/PVE/Storage/ESXiPlugin.pm | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.p= m > index 19f23bb..fd0ef0a 100644 > --- a/src/PVE/Storage/ESXiPlugin.pm > +++ b/src/PVE/Storage/ESXiPlugin.pm > @@ -1010,14 +1010,19 @@ sub smbios1_uuid { > > if ( > $uuid =3D~ /^ > - ([0-9a-fA-F]{8}) > - ([0-9a-fA-F]{4}) > - ([0-9a-fA-F]{4}) > + ([0-9a-fA-F]{2}) > + ([0-9a-fA-F]{2}) > + ([0-9a-fA-F]{2}) > + ([0-9a-fA-F]{2}) > + ([0-9a-fA-F]{2}) > + ([0-9a-fA-F]{2}) > + ([0-9a-fA-F]{2}) > + ([0-9a-fA-F]{2}) > ([0-9a-fA-F]{4}) > ([0-9a-fA-F]{12}) > $/x > ) { > - return "$1-$2-$3-$4-$5"; > + return "$4$3$2$1-$6$5-$8$7-$9-$10"; > } > return; > }