From: "Elias Huhsovitz" <e.huhsovitz@proxmox.com>
To: "Jonas Theisen" <j.theisen@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH pve-manager] Web UI: VM creation Wizard: Pupulate EFI and TPM storage by default
Date: Wed, 05 Aug 2026 10:49:23 +0200 [thread overview]
Message-ID: <DKGVPX5BAWGM.JWIPM5O2CVIE@proxmox.com> (raw)
In-Reply-To: <20260803110534.149543-1-j.theisen@proxmox.com>
Nice quality of life change! Just one small bug:
The "EFI Storage" and "TPM Storage" fields are only populated the first
time the options are selected.
Repeatedly selecting/unselecting the checkboxes "Addi EFI Disk" and "Add
TPM", will not cause the respective storage fields to be populated, reverting
to the old behaviour.
On Mon Aug 3, 2026 at 1:05 PM CEST, Jonas Theisen wrote:
> On VM creation the storage dropdown for EFI and TPM were empty,
> while the storage for VM disks was populated by default.
>
> This commit adds the parameters to the selectors to also populate
> the storage for EFI and TPM disks automatically.
>
> Reported by a forum user in https://forum.proxmox.com/threads/185473/
>
> Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
> ---
> www/manager6/qemu/HDEfi.js | 1 +
> www/manager6/qemu/HDTPM.js | 1 +
> www/manager6/qemu/SystemEdit.js | 2 ++
> 3 files changed, 4 insertions(+)
>
> diff --git a/www/manager6/qemu/HDEfi.js b/www/manager6/qemu/HDEfi.js
> index 1ae63add..b093a5d9 100644
> --- a/www/manager6/qemu/HDEfi.js
> +++ b/www/manager6/qemu/HDEfi.js
> @@ -63,6 +63,7 @@ Ext.define('PVE.qemu.EFIDiskInputPanel', {
> nodename: me.nodename,
> disabled: me.disabled,
> hideSize: true,
> + autoSelect: me.insideWizard,
> },
> {
> xtype: 'proxmoxcheckbox',
> diff --git a/www/manager6/qemu/HDTPM.js b/www/manager6/qemu/HDTPM.js
> index 947e3738..ee51b9ce 100644
> --- a/www/manager6/qemu/HDTPM.js
> +++ b/www/manager6/qemu/HDTPM.js
> @@ -55,6 +55,7 @@ Ext.define('PVE.qemu.TPMDiskInputPanel', {
> nodename: me.nodename,
> disabled: me.disabled,
> hideSize: true,
> + autoSelect: me.insideWizard,
> },
> {
> xtype: 'proxmoxKVComboBox',
> diff --git a/www/manager6/qemu/SystemEdit.js b/www/manager6/qemu/SystemEdit.js
> index 299be5f8..458cb493 100644
> --- a/www/manager6/qemu/SystemEdit.js
> +++ b/www/manager6/qemu/SystemEdit.js
> @@ -137,6 +137,7 @@ Ext.define('PVE.qemu.SystemInputPanel', {
> hidden: true,
> hideSize: true,
> usesEFI: true,
> + insideWizard: true,
> },
> ],
>
> @@ -184,6 +185,7 @@ Ext.define('PVE.qemu.SystemInputPanel', {
> },
> disabled: true,
> hidden: true,
> + insideWizard: true,
> },
> ],
> });
next prev parent reply other threads:[~2026-08-05 8:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 11:05 [PATCH pve-manager] Web UI: VM creation Wizard: Pupulate EFI and TPM storage by default Jonas Theisen
2026-08-05 8:49 ` Elias Huhsovitz [this message]
2026-08-05 10:03 ` Jonas Theisen
2026-08-05 13:52 ` [PATCH manager] ui: vm: create: fix autoSelect for disk storage selector when re-enabling field Elias Huhsovitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DKGVPX5BAWGM.JWIPM5O2CVIE@proxmox.com \
--to=e.huhsovitz@proxmox.com \
--cc=j.theisen@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.