From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 8462E1FF0E3 for ; Tue, 04 Aug 2026 13:02:35 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 9C35B21627; Tue, 04 Aug 2026 13:02:33 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 04 Aug 2026 13:02:28 +0200 Message-Id: From: "Elias Huhsovitz" To: "Thomas Ellmenreich" , Subject: Re: [PATCH proxmox-acme v3 2/2] fix #5978: pem parser: relax parsing of chain entries: X-Mailer: aerc 0.20.0 References: <20260703105133.77817-1-t.ellmenreich@proxmox.com> <20260703105133.77817-3-t.ellmenreich@proxmox.com> In-Reply-To: <20260703105133.77817-3-t.ellmenreich@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785841336720 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.110 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: TJARUKZHUZXUDFABWBP5AAEJRBFC4YSP X-Message-ID-Hash: TJARUKZHUZXUDFABWBP5AAEJRBFC4YSP X-MailFrom: e.huhsovitz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri Jul 3, 2026 at 12:51 PM CEST, Thomas Ellmenreich wrote: > Instead of using a custom regex to parse pem chains, now uses > the pve-common Certificate::check_pem function to do so. This > now allows for additional text and whitespace inbetween the > chain entries. > > Signed-off-by: Thomas Ellmenreich > --- Good change to use standard pve-common implementation instead of custom regex! See comments below. > src/PVE/ACME.pm | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/src/PVE/ACME.pm b/src/PVE/ACME.pm > index e6fb9c2..7adda25 100644 > --- a/src/PVE/ACME.pm > +++ b/src/PVE/ACME.pm > @@ -526,14 +526,15 @@ sub get_certificate { > } > } > } > - die "no matching alternate chain for '$root' returned by ser= ver\n" > + die "no matching alternate chain for '$root' provided by the= acme server\n" > if !defined($res); > } > =20 > - if ($res =3D~ /^(-----BEGIN CERTIFICATE-----)(.+)(-----END CERTI= FICATE-----)$/s) { # untaint > - return $1 . $2 . $3; > - } > - die "Server reply does not look like a PEM encoded certificate\n= "; > + my $parsed =3D eval { PVE::Certificate::check_pem($res, multiple= =3D> 1) }; > + die > + "value returned by acme certificate url does not look like a= PEM encoded certificate: $@\n" > + if $@; nit: Error message inside of $@ might contain trailing newline. Consider remvoing the newline before die statement. e.g., die "value returned by ACME certificate url does not look like a PEM encode= d certificate: " . chomp($@) . "\n" if $@; nit: in the error message "PEM" is capitalized by "acme" is not. Capitalize= both for consistency. e.g., code sample above. > + return $parsed; > }; > $self->fatal("POST of '$order->{certificate}' failed - $@", $r) if $= @; > return $return;