From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 412291FF0F0 for ; Mon, 03 Aug 2026 15:27:41 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 90C2921322; Mon, 03 Aug 2026 15:27:40 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 03 Aug 2026 15:27:36 +0200 Message-Id: Subject: Re: [PATCH common/manager/proxmox-widget-toolkit/storage/storage-plugin-examples v3 00/17] GUI Support for Custom Storage Plugins From: "Jakob Klocker" To: "Jakob Klocker" , "Max R. Carrara" , X-Mailer: aerc 0.20.0 References: <20260727143445.513900-1-m.carrara@proxmox.com> In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785763646550 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.950 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: TLHWRTUB4X22HZJFESOBOP5S75IXRF5L X-Message-ID-Hash: TLHWRTUB4X22HZJFESOBOP5S75IXRF5L X-MailFrom: j.klocker@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon Aug 3, 2026 at 1:50 PM CEST, Jakob Klocker wrote: > I ran the same tests as in the previous version: > > - adding sshfs plugin over the GUI > - editing a plugin over the GUI > - removing a plugin over the GUI To clarify the above: I meant adding/editing/removing a storage of type sshfs via the GUI, not the plugin itself. > - checking the output of the new endpoints > > everything worked as expected. > > With the changes from the previous versions the code looks good to me. > Note that I don't have that much experience with the frontend, but > from what I can tell everything looks good. > > A small side note: there isn't a unified Makefile style across the > codebase, which would make sense to have. > > With that said, thanks for the patches and consider this: > > Reviewed-by: Jakob Klocker > Tested-by: Jakob Klocker > On Mon Jul 27, 2026 at 4:34 PM CEST, Max R. Carrara wrote: >> GUI Support for Custom Storage Plugins - v3 >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> >> Notable Changes Since v2 >> ------------------------ >> >> [SNIP]