Re: [PATCH common/manager/proxmox-widget-toolkit/storage/storage-plugin-examples v3 00/17] GUI Support for Custom Storage Plugins

["Jakob Klocker" <j.klocker@proxmox.com>]

I ran the same tests as in the previous version:

- adding sshfs plugin over the GUI
- editing a plugin over the GUI
- removing a plugin over the GUI
- checking the output of the new endpoints

everything worked as expected.

With the changes from the previous versions the code looks good to me.
Note that I don't have that much experience with the frontend, but
from what I can tell everything looks good.

A small side note: there isn't a unified Makefile style across the
codebase, which would make sense to have.

With that said, thanks for the patches and consider this:

Reviewed-by: Jakob Klocker <j.klocker@proxmox.com>
Tested-by: Jakob Klocker <j.klocker@proxmox.com>
On Mon Jul 27, 2026 at 4:34 PM CEST, Max R. Carrara wrote:
> GUI Support for Custom Storage Plugins - v3
> ===========================================
>
> Notable Changes Since v2
> ------------------------
>
> - Drop the patternProperties RFC patches.
>
>   After some additional consideration, I decided that supporting
>   patternProperties is out of scope for this series, and probably
>   something that deserves its own series instead.
>
>   In turn, the 'x-advanced' and 'x-hidden' keys in the plugin property
>   schema returned by the new API endpoint are now set through two
>   new hashes in `plugindata()`. This means that each plugin has to
>   define which properties it considers advanced and which should be
>   hidden in the UI itself, just like with sensitive properties.
>
> - Rename the 'sensitive' key that is returned as part of the plugin
>   property schema by the new API endpoint to 'x-sensitive'. This is done
>   in order to make it clear that this keyword is not part of our overall
>   JSON schema, since each plugins' properties' schemas are returned
>   directly.
>
>   Note that we can still "promote" 'x-sensitive' and have it exist in
>   the general JSON schema as 'sensitive' at some point in the future,
>   but that's out of scope for this series.
>
> - Sort modules in patch #13 (thanks @Jakob for the suggestion!)
>
> - Update the SSHFS example plugin and make use of the new hashes in
>   `plugindata()`, `title` keys in `properties()`, and also bump it's API
>   version, with all changes that are necessary for this.
>
> Thanks again to everyone who reviewed and/or tested the previous
> iterations of this series, as well as to those that provided feedback!
> It's much appreciated.
>
> Previous Versions
> -----------------
>
> rfc-v1: https://lore.proxmox.com/pve-devel/20250908180058.530119-1-m.carrara@proxmox.com/
> rfc-v2: https://lore.proxmox.com/pve-devel/20251121165858.818307-1-m.carrara@proxmox.com/
> v1: https://lore.proxmox.com/pve-devel/20260623143402.772452-1-m.carrara@proxmox.com/
> v2: https://lore.proxmox.com/pve-devel/20260717154943.696411-1-m.carrara@proxmox.com/
> [SNIP]