From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id B49A91FF0E2 for ; Thu, 30 Jul 2026 17:09:07 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 77A7F213DC; Thu, 30 Jul 2026 17:09:07 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 30 Jul 2026 17:09:02 +0200 Message-Id: Subject: Re: [PATCH proxmox-backup 6/7] acme: fix #6372 implement ARI renewal information fetching. From: "Shan Shaji" To: "Manuel Federanko" , , X-Mailer: aerc 0.20.0 References: <20260625141337.181684-1-m.federanko@proxmox.com> <20260625141337.181684-7-m.federanko@proxmox.com> In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785424134372 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.123 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GC6FKFPURBW564K3QVXGJWEMPYQUFCOB X-Message-ID-Hash: GC6FKFPURBW564K3QVXGJWEMPYQUFCOB X-MailFrom: s.shaji@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed Jul 29, 2026 at 11:07 AM CEST, Manuel Federanko wrote: [snip] >>> diff --git a/src/bin/proxmox_backup_manager/acme.rs b/src/bin/proxmox_b= ackup_manager/acme.rs >>> index ed9e5868c..ea14cfe2b 100644 >>> --- a/src/bin/proxmox_backup_manager/acme.rs >>> +++ b/src/bin/proxmox_backup_manager/acme.rs >>> @@ -413,14 +413,6 @@ pub fn plugin_cli() -> CommandLineInterface { >>> )] >>> /// Order a new ACME certificate. >>> async fn order_acme_cert(param: Value, rpcenv: &mut dyn RpcEnvironment= ) -> Result<(), Error> { >>> - if !param["force"].as_bool().unwrap_or(false) { >>> - let (expires_soon, lead_days) =3D api2::node::certificates::ch= eck_renewal_needed()?; >>> - if !expires_soon { >>> - println!("Certificate does not expire within the next {lea= d_days} days, not renewing."); >>> - return Ok(()); >>> - } >>> - } >>> - >>=20 >> Hi, Since this was now removed, we no longer get console feedback If the >> certificate doesn't expire soon. However, the status was visible inside = the >> task log. Would showing it in the console as well be a good UX? > Agreed, I'd prefer that too, I'm unsure on how to achieve this I have checked this one and AFAIU, this is because of our logger intialization, where logs are written to the stderr only if no workertask context exists or the event level is error. When I created the logger with = the plain_stderr_layer, i.e without the NoWorkerTask filter the log was visible in the console. I don't think that would be a good idea because now all the logs inside the workertask context will be written to stderr. Alternatively, wit= hout changing the filters, replacing the info! call for the =E2=80=9CCertificate= does not expire...=E2=80=9D message with println! would write it to stdout However, in that case, the message would no longer be written to the task log. > acme check is imo better handled in the worker. Agreed, However without moving the check earlier, I am not sure what is the best way to handle this. Perhaps others have a better suggestion here. :) >>=20 >>> let info =3D &api2::node::certificates::API_METHOD_RENEW_ACME_CERT= ; >>> let result =3D match info.handler { >>> ApiHandler::Sync(handler) =3D> (handler)(param, info, rpcenv)?= , >>> -- >>> 2.47.3 >>=20