Re: [PATCH proxmox-backup 04/11] config/server/api: add certificate renewal logic including notifications

["Lukas Wagner" <l.wagner@proxmox.com>]

On Wed Jul 29, 2026 at 12:13 PM CEST, Shannon Sterz wrote:
> On Wed Jul 29, 2026 at 12:08 PM CEST, Lukas Wagner wrote:
>> On Wed Jul 29, 2026 at 11:53 AM CEST, Shannon Sterz wrote:
>
> -->8 snip 8<--
>
>>>>> +Proxmox Backup Server will refresh its TLS certificate within the next 30 days.
>>>>
>>>> I wonder, would it be possible to include a concrete date here? If I
>>>> understood it correctly, the first time the user receives this
>>>> notification, the renewal would be first attempted in 15 days at the
>>>> earliest, so maybe this should be mentioned.
>>>
>>> i can add a line that the earliest a certificate will updated is in X
>>> days.
>>>
>>> adding a date is imo a bit trickier due to localization. as far as i can
>>> tell, handlebars [1] currently has no date formatting helpers. so either
>>> we implement our own, which seems orthogonal to this series and probably
>>> not worth it if we do decide to switch templating engines in the near
>>> future. or we don't care about localization and simply decide on one
>>> format (e.g. YYYY-MM-DD).
>>>
>>> what do you think?
>>>
>>> [1]: https://github.com/sunng87/handlebars-rust/issues/614
>>
>> Notifications are not localized at all right now, so I think if we just
>> use ISO 8601 (so YYYY-MM-DD), it should be clear enough for most users.
>
> ack, i mostly thought of users doing localization themselves by
> overriding the templates, but will do that then.

Yeah, of course it could make sense to add custom helper for localized
date formatting at some point. Since we kind of have a switch to
minijinja on the horizon, I'd not any additional helpers to our
handlebars implementation at the moment, and rather use the
existing `timestamp` helper (e.g. {{ timestamp cert-refresh-ts }}), it'll print
the timestamp as YYYY-MM-DD HH:MM:SS