From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 923B61FF0E4 for ; Tue, 28 Jul 2026 13:59:02 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 04BC721325; Tue, 28 Jul 2026 13:59:02 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 28 Jul 2026 13:58:57 +0200 Message-Id: From: "Lukas Sichert" To: "Stefan Hanreich" , Subject: Re: [PATCH pve-network 3/3] fix #7738: zones: use pre-computed bridge port list References: <20260709132857.239615-1-s.hanreich@proxmox.com> <20260709132857.239615-4-s.hanreich@proxmox.com> In-Reply-To: <20260709132857.239615-4-s.hanreich@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785239900583 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.070 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JWWCGVU7VCNANZTRF4H7AXI3BDOJMHSI X-Message-ID-Hash: JWWCGVU7VCNANZTRF4H7AXI3BDOJMHSI X-MailFrom: l.sichert@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2026-07-09 15:28, Stefan Hanreich wrote: > The VLAN and QinQ zone utilized ip_link_details to obtain information > about the physical ports contained on a bridge. Instead of executing > iproute2 and computing the bridge ports for every VNet, precalculate > the bridge port list using the new helper in pve-common and then > re-use the ouput obtained at the start of the run. > > Remove the get_bridge_ifaces function, since there are no longer any > call sites for this function. > > Signed-off-by: Stefan Hanreich Moving the `ip_link_details` call and the corresponding parsing outside the per-VNet loop makes a lot of sense. This reduced the reload time reported by the GUI from 12 minutes to slightly over 1 minute with 1,000 VLAN zones and 1,000 QinQ zones. Therefore, please consider this: Reviewed-by: Lukas Sichert Tested-by: Lukas Sichert